Snowfakery icon indicating copy to clipboard operation
Snowfakery copied to clipboard

Updated to Pydantic 2 (superset of Jason's)

Open prescod opened this issue 1 year ago • 4 comments
trafficstars

Obsoletes #1018

prescod avatar Apr 06 '24 00:04 prescod

@jstvz

The current test failure is because CCI is on Pydantic 1 while Snowfakery is on Pydantic 2.

Do you want to:

a) upgrade CCI and Snowfakery to Pydantic 2 in a single coordinated release or

b) support Pydantic 1 and 2 simultaneously in Snowfakery so that they can upgrade in a staggered manner?

prescod avatar Apr 11 '24 01:04 prescod

Obviously b) involves ugly cruft that will need to be removed eventually.

prescod avatar Apr 11 '24 01:04 prescod

@jstvz

The current test failure is because CCI is on Pydantic 1 while Snowfakery is on Pydantic 2.

Do you want to:

a) upgrade CCI and Snowfakery to Pydantic 2 in a single coordinated release or

b) support Pydantic 1 and 2 simultaneously in Snowfakery so that they can upgrade in a staggered manner?

Option (a) is my preference.

jstvz avatar Apr 22 '24 15:04 jstvz

@jstvz . Okay, ping me when the time comes if there are challenges on the Snowfakery side. It actually doesn’t thave a lot of Pydantic stuff in it and arguably what it does have should move to the CCI repo because it relates to CCI.

prescod avatar Apr 22 '24 15:04 prescod

Is there any progress on this PR? We are using snowfakery in our project and would love to update it to pydantic V2 like our other dependencies.

I would be willing to help if that is possible

kwendel avatar Apr 24 '25 13:04 kwendel

@prescod @jstvz is there any progress in merging this? Pydantic V1 is going to be out of support soon, see https://docs.pydantic.dev/2.5/version-policy/

kwendel avatar Jul 08 '25 08:07 kwendel

@kwendel Thanks for the reminder. This PR is currently blocked by a dependency on CumulusCI, which also needs a Pydantic V2 upgrade. I'm bumping the priority with the team internally and will update you here.

jstvz avatar Jul 10 '25 18:07 jstvz