CumulusCI
CumulusCI copied to clipboard
SFDO-Tooling
Update SalesforcePlaywright.py
-
Suggested change: Increase default timeout to 90 seconds as 15 seconds is not long enough for some processes and browser will incorrectly timeout
-
Suggested change, increase viewport size as some items get truncated and robot doesn't find them. 1080x1920 has been ok for us without issue.
Added some additional keywords which we use in Q brix which can be really helpful
@GeekStewie Unfortunately we no longer have a Robot Framework expert on our team (still less a Playwright expert). These changes make perfect sense to me, and I assume you're using them in production?
Could you add Robot tests in cumulusci/robotframework/tests/salesforce/playwright/playwright.robot?
Yes these are a copy of the settings we have been using for the last few months in prod. It will save us making a version of our own and we can just use the cumulusci robot setup without any modifications if these are applied.
On Mon, 31 Jul 2023 at 22:46, David Reed @.***> wrote:
@GeekStewie https://github.com/GeekStewie Unfortunately we no longer have a Robot Framework expert on our team (still less a Playwright expert). These changes make perfect sense to me, and I assume you're using them in production?
Could you add Robot tests in cumulusci/robotframework/tests/salesforce/playwright/playwright.robot?
— Reply to this email directly, view it on GitHub https://github.com/SFDO-Tooling/CumulusCI/pull/3626#issuecomment-1659223754, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPTVVK2X2KN2PJB5EW4GCDXTARSHANCNFSM6AAAAAA2O5T5FE . You are receiving this because you were mentioned.Message ID: @.***>
-- Stewart Anderson
Lead Solution Developer - Salesforce.org
@GeekStewie Unfortunately we no longer have a Robot Framework expert on our team (still less a Playwright expert). These changes make perfect sense to me, and I assume you're using them in production?
Could you add Robot tests in
cumulusci/robotframework/tests/salesforce/playwright/playwright.robot?
Can you confirm what test needs to be added here? The changes apply to the Open test browser keyword which is already tested for in these tests in the suite setup and teardown.