CumulusCI icon indicating copy to clipboard operation
CumulusCI copied to clipboard

Published 20 hours ago • verified publisher icon SFDO-Tooling

Use JSON instead of Pickle

Open bethbrains opened this issue 3 years ago • 1 comments
trafficstars

  • All new keychain details are serialized using json, not pickle.

bethbrains avatar Oct 11 '22 22:10 bethbrains

@bethbrains

We're going to have to support Dates and DateTimes.

https://github.com/SFDO-Tooling/CumulusCI/actions/runs/3230706675/jobs/5289461956#step:8:41

We need to use the default= parameter:

https://docs.python.org/3/library/json.html#json.dump

Like this:

https://github.com/SFDO-Tooling/CumulusCI/blob/15872d5da869d069122d086d8f6aeeba1ced2c17/cumulusci/utils/parallel/task_worker_queues/parallel_worker.py#L211

We should also do some kind of survey to figure out what other types we might need to support.

prescod avatar Oct 11 '22 23:10 prescod