CumulusCI icon indicating copy to clipboard operation
CumulusCI copied to clipboard

Unusual case in test_load

Open prescod opened this issue 5 years ago • 4 comments

David, do you remember what you were trying to test here? It seems odd to have a Lookup declaration on an Id column. (i.e. the column is both a primary key and a lookup to another table)

Am I missing something or is this a typo?

https://github.com/SFDO-Tooling/CumulusCI/blob/158a2d4356f1ac149dd72a13e961ccef8d0f9ef9/cumulusci/tasks/bulkdata/tests/test_load.py#L352

prescod avatar May 30 '20 23:05 prescod

Yeah, that is a horrible hack. I think the original intent was a negative test - to include a lookup that was guaranteed not to generate an after step. No idea why I called it Id. I'll fix it.

davidmreed avatar Jun 01 '20 17:06 davidmreed

I think that there were a couple of places the pattern occurred in that file. Thanks for looking at it.

prescod avatar Jun 01 '20 18:06 prescod

@davidmreed this is still outstanding, right?

davisagli avatar Aug 07 '20 15:08 davisagli

Yes, @davisagli, I need to revisit that test case.

davidmreed avatar Aug 07 '20 16:08 davidmreed