andy icon indicating copy to clipboard operation
andy copied to clipboard

Eliminated Boolean Arguments From getNumberOfPassedChecks and getTotalNumberOfChecks

Open vesk4000 opened this issue 1 year ago • 0 comments

Closes #219.

Refactored a few methods in the CodeChecksResult class:

  • getNumberOfPassedChecks() is now getWeightedNumberOfPassedChecks();
  • removed getNumberOfPassedChecks(boolean includeWeight);
  • added getUnweightedNumberOfPassedChecks();
  • getTotalNumberOfChecks() is now getTotalWeightedNumberOfChecks();
  • removed getTotalNumberOfChecks(boolean includeWeight);
  • added getTotalUnweightedNumberOfChecks().

Fixed the method calls, of course, and the behaviour is exactly the same. I wasn't sure if I should refactor getTotalNumberOfChecks, in addition to getNumberOfPassedChecks, but I did anyway, since it seemed sensible.

vesk4000 avatar Sep 24 '23 16:09 vesk4000