seed
seed copied to clipboard
Fix: Use old cycles during unmerge
In contrast to https://github.com/SEED-platform/seed/issues/3904, here's the new workflow
Okay, so we've got a property present in two cycles, one has been merged into:
see?
Now if we unmerge the merged one:
We've one got one new property:
@kflemin @axelstudios the failing test here imply this intented behavoir. why? Is it still?
I don't have any historical context for this one. @nllong? @axelstudios? Basically, what we are trying to do here is: when we unmerge 2 properties, we want to associate one of the unmerged properties back to the "old" existing property and create a new property for the other unmerged property. This is in contrast to what happens now: when a property is "unmerged" into 2, it creates 2 new properties.
@kflemin @axelstudios repinging this
Resolution:
- assign meters to both properties
- 1 of the unmerged properties should retain the history
- in the notes of the property that has no history, add a note "unmerged from X" so we still retain a link to the history (db table note)
@kflemin In the note, what field should I use the reference the other Property?
@kflemin In the note, what field should I use the reference the other Property?
Let's reference the property view ID (since users don't have access to property IDs directly).