seed Investigate labelling for filter groups

Question: When filter group has specific labels, should inapplicable labels be hidden when the cycle doesn't include them? Should they be restored when changing cycles if a label suddenly applies?

This was "Yes-" for 3/31 release

Mar 22 '23 17:03 isalanglois

Let me flush out topic a bit:

I have two Cycles, 2021 & 2022.
Each cycle has the same two properties, IDs 13 & 16.
In cycle 2022, property 13 has the label "Boo!". this label exists no where else.
I have a filtergroup, "Boo!", which filters in only properties with the label "Boo!"

2021: 2022:

Currently, if I'm on cycle 2022, with filter group "Boo!" applied, then I switch to cycle 2021, the filter group will still be active, but the label filter will not be applied, as the label "Boo!" is not present on cycle 2022.

What's more, if I switchback to 2022, "Boo!" continues to not be be applied.
2022 w/ filter" switch to 2021: switch back:

what's the desired behavior?

Mar 23 '23 19:03 haneslinger

This problem stems for the fact in https://github.com/SEED-platform/seed/issues/3818, we've stopped applying labels on cycles where they do not exist.

this causes several problems/inconsistencies:

Even when the label logic is set to exlcude, you still can select labels that are not present.
Currently when you switch cycles, if a label doesn't apply to the new cycle, it disappears. Is this the desired functionally? If so, this functionally is inconsistent with the ui-grid filters, which don't disappear if they filter out all inventory.
The above point causes filter groups to break as explained in the above ticket.

I say we undo https://github.com/SEED-platform/seed/issues/3818. If we don't, we will have to recon with the problems listed above.

Mar 23 '23 21:03 haneslinger