seed icon indicating copy to clipboard operation
seed copied to clipboard

Fix issue caused by Filter Groups where Inventory Page is loaded twice

Open anchapin opened this issue 2 years ago • 2 comments

When the inventory page is loaded or refreshed, it loads the table twice instead of just one time. This issue started after Filter Groups were added.

anchapin avatar Sep 01 '22 20:09 anchapin

Every time the filter group updates, updateCurrentFilterGroup is called.

updateCurrentFilterGroup calls filterUsingLabels and potentially alters gridApi.grid.columns[i].filters, both of which load the inventory (filterUsingLabels, onfiltersChange).

We could just refactor filterUsingLabels so it doesn't call load_inventory, but there's no promise that the filter group will change the filters and call load_inventory.

idk what the right move is here. thoughts?

haneslinger avatar Oct 10 '22 17:10 haneslinger

@axelstudios When you get back, can help take a look?

isalanglois avatar Oct 18 '22 17:10 isalanglois

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 18 '22 01:12 github-actions[bot]