seed icon indicating copy to clipboard operation
seed copied to clipboard

Unable to create labels in suborg

Open nllong opened this issue 3 years ago • 2 comments

Create a sub org and try to create a label using the UI.

nllong avatar Jun 03 '22 16:06 nllong

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 03 '22 02:08 github-actions[bot]

Marking as p-1 to keep it from becoming stable.

nllong avatar Aug 03 '22 18:08 nllong

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 15 '22 02:10 github-actions[bot]

I will test on the latest dev solution

RDmitchell avatar Oct 18 '22 19:10 RDmitchell

Instance: dev1 SHA: f9558b8bb Org LBNL 101 SubOrg2 RM+20

It is possible to add labels to data in a sub org, but the labels are not showing up in the List View, at least for the Tax Lot tab Jurisdiction Tax lot ID: 10102/5B193 has a label, as seen in the detail view (added in List view) image But in the list view, you can't display the labels image

The same is true for the Property Tab List View This record has a label image

But it doesn't appear in the List View image

RDmitchell avatar Oct 21 '22 00:10 RDmitchell

The reason why the labels aren't showing up in the List View is because I didn't specify "Show in List", which is set in Org/Labels. image

When I go to the Org/Labels view for the suborg (LBNL 101 SubOrg 2) I don't see any labels. image

But in the Property List View for that Suborg, I am able to add labels "on the fly" image image

RDmitchell avatar Oct 21 '22 17:10 RDmitchell

When I try to create a label "on the fly" from the Property List, when I click the Done button, I get a 500 error image

RDmitchell avatar Oct 21 '22 18:10 RDmitchell

I'm seeing the issue on my end also where you can't create a new label from the suborg, however, I did notice that when I assign a label to a suborg property that was set as "Show in List" in the parent org, then I can see it in the Inventory List.

The question I have then is whether we want users of the suborg to be able to create and edit labels? Additionally, would we want the labels and the label settings, such as "Show in List" toggle, to sync between the org and suborg or be unique? This type of situation will need to get vetted prior to or during the upcoming account hierarchy tasks.

anchapin avatar Oct 21 '22 19:10 anchapin

@anchapin that is exactly the right question. I suggest we add this discussion to the accountability hierarchy discussion, that is, where do labels live within a hierarchy? How does that impact hierarchical aggregations? Adding in @haneslinger too.

nllong avatar Oct 23 '22 14:10 nllong

My assumption is that sub orgs were not designed to be allowed to create/delete/edit labels, however, the "on the fly" label creation was forgotten about. That's why it returns a 500: it was never suppose it work.

In my accountability hierarchy proposal, I dissolve suborgs as we know them completely, as their implementation is not robust enough carry the requested functionality. In the proposal, orgs contain groups, and each group either has a parent ( like a sub org) or is the singular "root group" for that org.

As in the current implementation, not root groups should not be able to create/edit/delete labels. We should be mindful not to forget the "on the fly" ui while we implement.

My point is: This will all have to be refactored anyway, so let's close the ticket

haneslinger avatar Oct 24 '22 18:10 haneslinger

@haneslinger -- I think your proposal makes sense. I don't think anyone is using sub-orgs, and as you say, we will be completely refactoring that functionality for the accountability heirarchy.

So I do think it makes sense to close this issue. I will do that.

RDmitchell avatar Oct 24 '22 18:10 RDmitchell