seed icon indicating copy to clipboard operation
seed copied to clipboard

Import: bad UX when importing meters after properties import

Open macintoshpie opened this issue 3 years ago • 3 comments

context

After importing properties from a spreadsheet which includes meter data, SEED will eventually show a "Import Meter Data" button. Problem is that this button doesn't appear until the request is complete which can take some time.

For more context, see this comment/issue: https://github.com/SEED-platform/seed/issues/2810#issuecomment-956641141

In addition, if the file is sizable, after you click the "Import Meter Data" button it will look like it's just hanging.

task

  • refactor the button s.t. it's always visible. While the frontend makes the request checking if the file has meter data, we should show a spinning icon on the button (but it's disabled).
  • once we get a response from SEED: if we do have meter data, enable the button. If we don't, either hide the button or hide the spinner and keep it disabled. If we decide to continue showing the disabled button in latter case, we might want to add a tooltip explaining why it's disabled (there's no meters tab)
  • Update the modal state immediately after the user clicks the "Import Meter Data" button so that it doesn't look like it's just hanging. Maybe just show spinner again and disable all of the buttons?

macintoshpie avatar Nov 01 '21 21:11 macintoshpie

@macintoshpie -- not sure where this is in the list of priorities, but it's really easy to forget to wait for the Import Meters button to appear. I know about it and have forgotten several times, and then imported the meter data separately. Which isn't the end of the world. So maybe since there is that work around it is not so important to fix this now.

RDmitchell avatar Nov 05 '21 18:11 RDmitchell

@macintoshpie -- this might be another candidate for fixing once the users have tested staging.

RDmitchell avatar Nov 06 '21 01:11 RDmitchell

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 08 '22 02:10 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 08 '22 02:12 github-actions[bot]

I am moving this to Test and assigning it to myself, since it seems like it might have been fixed.

RDmitchell avatar Dec 08 '22 19:12 RDmitchell

Instance: Dev1 SHA: 05efb37bf

The import meter button now shows a progress bar when it is working and then eventually the button is live.

I'm not convinced that a progress bar on the button is the best UI for this, but it is good for now.

RDmitchell avatar Dec 16 '22 21:12 RDmitchell