SDWebImage
The behavior of aspectRatio between AnimatedImage and WebImage is not same
As screenshot shows, AnimatedImage with aspectRatio is larger/smaller than expected.
Environment: Xcode 15.1 beta, iOS 17 Demo Project: SDDisplayDemo.zip
For animated image, to workaround a old iOS 13 issue, the actual image view is the subview of an container. And use auto layout to edge align to edge of that container
This history work on iOS 13-16, seems broken. Don't know whether compatible issue with auto layout with SwiftUI 's layout system or other case
Need time to investigate
Seems the bug still exists....
Do you knwo the layout constraint about auto layout X SwiftUI ? Need more time or other people to help with this.
Can you try to investigate ad debug by checking the AnimatedImageViewWrapper ?
What's the point of _AspectRatioLayout(aspectRatio: aspectRatio, contentMode: contentMode), I removed this and everything is ok now(only tested on iOS 17).
demo project: SDDisplayDemo.zip
It's used to implements the custom aspectRatio. Like 0.5
Not content mode. SwiftUI this modifier provide 2 function (transform) and (display scale mode) using the 1 API, which is hard for UIKit based to implements
I think the biggest bad design it that both WebImage and AnimatedImage try to copy the API design from SwiftUI.Image, which is totally wrong. Especially for async-loading images, there're no actual placeholder aspect ratio or content to place.
But it's introduced at the beginning, all the thing I wrote on the day 2019 :)
Try using
Image()
.resizable
.aspectRatio(0.5, .fit)
And compared with WebImage/AnimatedImage to see the result.
I think the behavior works on iOS 16-, but break on iOS 17+
You can test the lower version as well, from the iOS 14 ~ iOS 17, each iOS version need to test the behavior again.
