scons icon indicating copy to clipboard operation
scons copied to clipboard

scons-time: add filter to tarfile extract call.

Open mwichmann opened this issue 1 year ago • 0 comments

Python 3.13.0b1 added a warning when the extraction filter is not specified. The filter argument (to extract() and extractall()) was added in 3.12, but with no noise. Once the warning was added, the scons-time tests began to fail - this is a continuation of the work Red Hat did for RHEL 8 and RHEL 9 starting with Python 3.9. Supplying the filter quiets the warning, which also worked for the RHEL case.

The tarfile and zipfile usage now uses a context manager (both objects can be used this way since Python 3.2 or so).

This has no visible effects - scons-time is only used during testing. Not added to release note as bin/scons-time.py is not part of the released SCons wheel.

Contributor Checklist:

  • [X] I have created a new test or updated the unit tests to cover the new/changed functionality.
  • [X] I have updated CHANGES.txt (and read the README.rst)
  • [ ] I have updated the appropriate documentation

mwichmann avatar May 13 '24 13:05 mwichmann