scons icon indicating copy to clipboard operation
scons copied to clipboard
verified publisher icon SCons

Variables cleanup: EnumVariable

Open mwichmann opened this issue 1 year ago • 1 comments

Part 2 of a series, updating the EnumVariable implementation, tests and docstrings. While this is a small change, it looks bigger in the diff, due to the conversion of a series of lambdas to inner fuctions (fixing a pylint complaint)

  • [X] I have created a new test or updated the unit tests to cover the new/changed functionality.
  • [X] I have updated CHANGES.txt (and read the README.rst)
  • [X] I have updated the appropriate documentation

mwichmann avatar May 10 '24 12:05 mwichmann

No CHANGES.txt/RELEASE.txt?

bdbaddog avatar May 10 '24 20:05 bdbaddog

Looks good. If you can add a changes/release blurb. It's ready to merge.

bdbaddog avatar May 10 '24 21:05 bdbaddog

No CHANGES.txt/RELEASE.txt?

as noted, the comment for BoolVariable was intended to be generic across the series, so, no, no additional changelog.

mwichmann avatar May 10 '24 21:05 mwichmann