SCons
Non-conftest nodes involved in configure checks now get node info cleared after check.
Fixes #2757
from https://pairlist4.pair.net/pipermail/scons-users/2022-May/008989.html
Contributor Checklist:
- [x] I have created a new test or updated the unit tests to cover the new/changed functionality.
- [x] I have updated
CHANGES.txt(and read theREADME.rst) - [ ] I have updated the appropriate documentation
What happens when you run scons twice in a row where a real file is used by configure, but nothing depends on it? Does the configure step get rerun?
Not sure about the sider issue, should the code style remain consistent?
punt on this one. There'd be too much to fix.. We'll do a black run on the whole codebase at some point and then enforce.
What happens when you run scons twice in a row where a real file is used by configure, but nothing depends on it? Does the configure step get rerun?
No it uses the cached value. I updated the test to show this.
@dmoody256 - so from looking at the code, I think the only possible functional change is that if you were to only run the configure step and no actual build steps the sconsign would be missing the content signature information for all non-configure generated files uses while processing the configure checks?
Does that sound correct?
@dmoody256 - so from looking at the code, I think the only possible functional change is that if you were to only run the configure step and no actual build steps the sconsign would be missing the content signature information for all non-configure generated files uses while processing the configure checks?
Does that sound correct?
Yes