scons icon indicating copy to clipboard operation
scons copied to clipboard

build SCons packages with python tool 'build'

Open mwichmann opened this issue 4 years ago • 1 comments

Pushed to see if the GH Action will build this way (works locally). This an experiment to respond to the Py Packaging Authority's plea to "not call setup.py directly, use one of the tools". Don't see how to build the .zip file of the package this way, so at the moment that's commented out, with a question of whether we need. Does build the zipfile of the portable version. Updated: restored the old way of building the sdist-zipfile.

Update: this does seem to work, but I'll leave it as WIP, and it can be grabbed if wanted.

Changes only SCons' own build, not SCons itself, so no docs/tests/etc.

Contributor Checklist:

  • [ ] I have created a new test or updated the unit tests to cover the new/changed functionality.
  • [ ] I have updated CHANGES.txt (and read the README.rst)
  • [ ] I have updated the appropriate documentation

mwichmann avatar Nov 05 '21 16:11 mwichmann

From the Verify Package section of the GH Actions report:


1s
Run ls -l build/dist
total 23932
-rw-r--r-- 1 runner docker  4156653 Nov  5 19:23 SCons-4.2.0-py3-none-any.whl
-rw-r--r-- 1 runner docker  3120289 Nov  5 19:23 SCons-4.2.0.tar.gz
-rw-r--r-- 1 runner docker 10189706 Nov  5 19:25 scons-doc-4.2.0.tar.gz
-rw-r--r-- 1 runner docker  3018361 Nov  5 19:25 scons-local-4.2.0.tar.gz
-rw-r--r-- 1 runner docker  4017901 Nov  5 19:25 scons-local-4.2.0.zip
SCons by Steven Knight et al.:
	SCons: v4.2.0.cf664d3da93b5ad1eac48e4b5688e4fdea6231e6, Fri, 05 Nov 2021 19:22:24 +0000, by runner on fv-az269-943
	SCons path: ['/home/runner/work/scons/scons/build/scons-local/scons-local-4.2.0/SCons']
Copyright (c) 2001 - 2021 The SCons Foundation

mwichmann avatar Nov 05 '21 19:11 mwichmann

Is the pypi build module only Python 3.7+?

https://pypa-build.readthedocs.io/en/latest/installation.html

bdbaddog avatar Jul 16 '23 02:07 bdbaddog

I don't think so, I think the limitation is they're only testing with supported Python versions, which 3.6 no longer is. However, will have to verify that - if it matters. I'd doubt anyone is going to build the wheel to upload to pypi with the oldest Python version.

mwichmann avatar Jul 16 '23 17:07 mwichmann

I don't think so, I think the limitation is they're only testing with supported Python versions, which 3.6 no longer is. However, will have to verify that - if it matters. I'd doubt anyone is going to build the wheel to upload to pypi with the oldest Python version.

Indeed.

bdbaddog avatar Jul 16 '23 18:07 bdbaddog

Merging

bdbaddog avatar Jul 16 '23 18:07 bdbaddog