ShapeWorks icon indicating copy to clipboard operation
ShapeWorks copied to clipboard

All issues related shared bounday use case

Open iyerkrithika21 opened this issue 3 years ago • 5 comments

The use case has a few commands which are hardcoded. - done The necessary commands should be consolidated and replaced with the python API calls - done The following commands have to be changed:

  • [x] Consolidate shared_boundary_extractor.cpp and boundary_loop_extractor.cpp #1583
  • [x] Update the use case to use OptimizeUtils/AnalyzeUtils #1584
  • [x] Remeshing #1585
  • [ ] #1234

Studio:

  • [ ] Shared boundary studio updates #1383

Other related tasks that are in the research stage:

  • [ ] Shared boundary weights across domains #1780
  • [ ] Geodesics across shared boundaries #1215
  • [ ] Quality control output of topologyPreservingSmooth #1381

The use case in python and studio should follow the steps:

  1. Given the input data, identify the pairs of data that have shared boundary
  2. If there are no shared boundaries, notify the user and proceed to build the shape model considering this a case of multiple domains
  3. If shard boundaries exist, then let the user know and proceed to build a shape model with mixed domain

iyerkrithika21 avatar Jul 06 '21 16:07 iyerkrithika21

Questions:

  1. There are 4 domains per shape in the use case - left, right, shared surface meshes, and boundary loop contour. How to update OptmizeUtils.py for such a use case which uses more than one input type?

iyerkrithika21 avatar Aug 09 '21 20:08 iyerkrithika21

  1. There are 4 domains per shape in the use case - left, right, shared surface meshes, and boundary loop contour. How to update OptmizeUtils.py for such a use case which uses more than one input type?

We might want to split this issue out into separate issues that can be independently addressed.

cchriste avatar Oct 12 '21 23:10 cchriste

Agreed. We can use this issue as the parent one for the subissues.

sheryjoe avatar Oct 13 '21 14:10 sheryjoe

@iyerkrithika21 , has this been completed?

akenmorris avatar May 09 '23 17:05 akenmorris

@iyerkrithika21 , has this been completed?

We have implemented the shared boundary use case in python but two issues remain open:

  1. https://github.com/SCIInstitute/ShapeWorks/issues/1234 This is a general issue with mesh smoothening not particularly related to shared boundary use case
  2. #1383 where we were hoping to include the shared boundary detection and optimization in studio.

iyerkrithika21 avatar May 10 '23 18:05 iyerkrithika21