Seg3D icon indicating copy to clipboard operation
Seg3D copied to clipboard

Better font rendering on OSX

Open allywarner opened this issue 4 years ago • 10 comments

Fixes widgets being squished as well on OSX.

allywarner avatar Jun 23 '20 20:06 allywarner

Closes #349 and hopefully #132, but Windows still has squished widgets on high resolution monitors.

allywarner avatar Jun 23 '20 20:06 allywarner

I made a build and an installer and didn't notice a change. Qt 5.14/MacOS 10.14. I deleted all from Superbuild down. Do I need to blow everything away? I'll try one more time.

image

dcwhite avatar Jun 23 '20 20:06 dcwhite

even after a fresh build, doesn't seem to do anything to the fonts

jessdtate avatar Jul 08 '20 21:07 jessdtate

Alan 3:52 PM One thing that you have to keep in mind is that OSX now caches plist files, and if you just edit it for a .app, you won't see any change.

You can force it with a "defaults read /path/to/plist" as I recall.

Another thing you can do is copy it to a new location.

This has confused me many times.

dcwhite avatar Jul 14 '20 23:07 dcwhite

@allywarner If we can get this one to work, it should be merged before the version update, yeah?

dcwhite avatar Jul 14 '20 23:07 dcwhite

@dcwhite I think so! It'd be a nice addition.

allywarner avatar Jul 14 '20 23:07 allywarner

I think the problem is the actual bundle plist file is not getting this change. I'll check the cpack code

dcwhite avatar Jul 16 '20 23:07 dcwhite

Yes, there are deeper problems here. The plist file that winds up in the bundle is hard-coded and located in src/Resources/. So that one would get the NSHighResolutionCapable key addition. There are two .plist.in files in the CMake/Modules directory, and they're both ignored (and both are a mess of duplicated keys it seems). So this needs more clean up. I'll investigate more tomorrow.

dcwhite avatar Jul 16 '20 23:07 dcwhite

@jessdtate We figured out how to get improved font rendering (make the same small change, but to a different plist file) but uncovered some sloppy messiness related to the plist files in the repo. Should we (a) clean up the messiness now or (b) make the quick fix to get the fonts working before the release?

dcwhite avatar Jul 21 '20 22:07 dcwhite

let's fix it in the next release. I think we are ready to go otherwise.

jessdtate avatar Jul 22 '20 07:07 jessdtate