SCIRun icon indicating copy to clipboard operation
SCIRun copied to clipboard

Performance of undo/redo when network.size > 60

Open dcwhite opened this issue 11 years ago • 9 comments

Bad performance when network gets big, as expected. Will need to work hard on optimization.

dcwhite avatar Apr 03 '13 19:04 dcwhite

@SCIInstitute/cibc-users @SCIInstitute/scirun-users @SCIInstitute/scirun-developers Another user poll: Has anyone noticed this slowdown? In general, how should we go about provenance in large network files?

dcwhite avatar Feb 27 '17 20:02 dcwhite

Provenance is part of it, but there the networks can be quite slow even when freshly loaded. As for provenance, if we could set the number of steps (for undo) in preference, then set the default to 10 or so, that would probably help.

jessdtate avatar Feb 28 '17 00:02 jessdtate

Sounds good. I'll put this on the list for 2017.

dcwhite avatar Feb 28 '17 18:02 dcwhite

Stale issue message

github-actions[bot] avatar Oct 29 '19 00:10 github-actions[bot]

@jessdtate Another one that Qt5 might solve.

dcwhite avatar Oct 29 '19 16:10 dcwhite

I just tested this on a network with 64 modules and the undo/redo step took ~ 3 s. It puts all the modules in the same location, like it does on load. Another network (120 modules) took about 6s, and a big network (>200) took about 10 s. Seems faster than qt4, but still a problem

jessdtate avatar Oct 30 '19 16:10 jessdtate

Indeed. The implementation sucks.

dcwhite avatar Oct 30 '19 16:10 dcwhite

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 60 days.

github-actions[bot] avatar Feb 28 '20 00:02 github-actions[bot]

This issue is stale because it has been open 240 days with no activity. Remove the stale label or comment, or this will be closed in 60 days.

github-actions[bot] avatar Apr 13 '21 00:04 github-actions[bot]