Inquirer.js
Inquirer.js copied to clipboard
Added an optional question value 'helper' and 'pageHelper'
I added an optional question value for custom help message on list type.
Codecov Report
Merging #975 (e9b2e2f) into master (ca70e03) will increase coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #975 +/- ##
==========================================
+ Coverage 93.30% 93.35% +0.04%
==========================================
Files 27 27
Lines 1121 1128 +7
Branches 23 23
==========================================
+ Hits 1046 1053 +7
Misses 75 75
Impacted Files | Coverage Δ | |
---|---|---|
packages/inquirer/lib/prompts/base.js | 91.48% <ø> (ø) |
|
packages/inquirer/lib/prompts/checkbox.js | 98.21% <100.00%> (+0.01%) |
:arrow_up: |
packages/inquirer/lib/prompts/editor.js | 92.50% <100.00%> (+0.19%) |
:arrow_up: |
packages/inquirer/lib/prompts/expand.js | 83.18% <100.00%> (+0.15%) |
:arrow_up: |
packages/inquirer/lib/prompts/list.js | 93.25% <100.00%> (+0.07%) |
:arrow_up: |
packages/inquirer/lib/prompts/rawlist.js | 98.86% <100.00%> (+0.01%) |
:arrow_up: |
packages/inquirer/lib/utils/paginator.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ca70e03...e9b2e2f. Read the comment docs.
Should document this change.
Hello. A user here.
Can you update the PR to include another list-specific option to change the end text, too?
Maybe an option called listOpts
can take an object having these two parameters because we wouldn't want to crowd the main options too much.
Hello. A user here.
Can you update the PR to include another list-specific option to change the end text, too?
Maybe an option called
listOpts
can take an object having these two parameters because we wouldn't want to crowd the main options too much.
Actually, there is no specific List option to this end text, it refers to its Paginator util. Anyways, I made that change and now you could custom it, check my latest commit :D
@JezerM That's great! Waiting for this to get reviewed.
You should think more about the documentation.
Please write the unit test for your code.
You should think more about the documentation.
Please write the unit test for your code.
I've never worked with testing before, but I'll try it~
You should think more about the documentation.
Please write the unit test for your code.
I tried to make the unit test, and went well (I guess).