Inquirer.js icon indicating copy to clipboard operation
Inquirer.js copied to clipboard

Added an optional question value 'helper' and 'pageHelper'

Open JezerM opened this issue 4 years ago • 8 comments

I added an optional question value for custom help message on list type.

JezerM avatar Oct 22 '20 20:10 JezerM

Codecov Report

Merging #975 (e9b2e2f) into master (ca70e03) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #975      +/-   ##
==========================================
+ Coverage   93.30%   93.35%   +0.04%     
==========================================
  Files          27       27              
  Lines        1121     1128       +7     
  Branches       23       23              
==========================================
+ Hits         1046     1053       +7     
  Misses         75       75              
Impacted Files Coverage Δ
packages/inquirer/lib/prompts/base.js 91.48% <ø> (ø)
packages/inquirer/lib/prompts/checkbox.js 98.21% <100.00%> (+0.01%) :arrow_up:
packages/inquirer/lib/prompts/editor.js 92.50% <100.00%> (+0.19%) :arrow_up:
packages/inquirer/lib/prompts/expand.js 83.18% <100.00%> (+0.15%) :arrow_up:
packages/inquirer/lib/prompts/list.js 93.25% <100.00%> (+0.07%) :arrow_up:
packages/inquirer/lib/prompts/rawlist.js 98.86% <100.00%> (+0.01%) :arrow_up:
packages/inquirer/lib/utils/paginator.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca70e03...e9b2e2f. Read the comment docs.

codecov[bot] avatar Oct 22 '20 21:10 codecov[bot]

Should document this change.

LitoMore avatar Nov 20 '20 07:11 LitoMore

Hello. A user here.

Can you update the PR to include another list-specific option to change the end text, too? image

Maybe an option called listOpts can take an object having these two parameters because we wouldn't want to crowd the main options too much.

abhijit-hota avatar Dec 07 '20 06:12 abhijit-hota

Hello. A user here.

Can you update the PR to include another list-specific option to change the end text, too? image

Maybe an option called listOpts can take an object having these two parameters because we wouldn't want to crowd the main options too much.

Actually, there is no specific List option to this end text, it refers to its Paginator util. Anyways, I made that change and now you could custom it, check my latest commit :D

JezerM avatar Dec 07 '20 20:12 JezerM

@JezerM That's great! Waiting for this to get reviewed.

abhijit-hota avatar Dec 08 '20 03:12 abhijit-hota

You should think more about the documentation.

Please write the unit test for your code.

LitoMore avatar Dec 08 '20 03:12 LitoMore

You should think more about the documentation.

Please write the unit test for your code.

I've never worked with testing before, but I'll try it~

JezerM avatar Dec 08 '20 17:12 JezerM

You should think more about the documentation.

Please write the unit test for your code.

I tried to make the unit test, and went well (I guess).

JezerM avatar Dec 08 '20 20:12 JezerM