fix: handle skipped questions in when with display option
- Display questions when when returns { ask: false, display: true } without adding to answers.
- Fully skip questions when when returns { ask: false, display: false } or false.
- Added tests to cover these cases.
Codecov Report
:x: Patch coverage is 97.56098% with 2 lines in your changes missing coverage. Please review.
:warning: Please upload report for BASE (main@7e6c3a2). Learn more about missing BASE report.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| packages/inquirer/src/ui/skipped-renderer.ts | 96.42% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1853 +/- ##
=======================================
Coverage ? 95.74%
=======================================
Files ? 46
Lines ? 2888
Branches ? 773
=======================================
Hits ? 2765
Misses ? 114
Partials ? 9
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Hey @SBoudrias , I’ve added more test cases and all checks are passing. Could you take a look when you get a chance and let me know if anything needs changes?
Rebased with latest main. Incorporated all the review changes (including normalization and theme updates). The reviewed fixes are now part of the existing commits after rebase.
Hi @SBoudrias , I’ve made the requested changes and resolved the conflicts. Please take a look when you have some time and let me know if I need to make any further changes. Thanks!
Hi! Just checking in on this PR whenever you get a chance. Let me know if anything else is needed from my side.