Inquirer.js icon indicating copy to clipboard operation
Inquirer.js copied to clipboard

Chore: Bump to Yarn 4 + enforce Node>=18

Open SBoudrias opened this issue 1 year ago • 1 comments

SBoudrias avatar Jan 07 '24 21:01 SBoudrias

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.43%. Comparing base (0dfa6bd) to head (7d6fe0b). Report is 7 commits behind head on master.

:exclamation: Current head 7d6fe0b differs from pull request most recent head 9e6e6de. Consider uploading reports for the commit 9e6e6de to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
- Coverage   94.46%   94.43%   -0.04%     
==========================================
  Files          53       51       -2     
  Lines        4556     4458      -98     
  Branches      772      773       +1     
==========================================
- Hits         4304     4210      -94     
+ Misses        247      243       -4     
  Partials        5        5              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 07 '24 21:01 codecov[bot]

Both https://github.com/actions/checkout and https://github.com/actions/setup-node have newer major version. We can bump them to the latest.

LitoMore avatar Feb 24 '24 08:02 LitoMore

For future reference in case. There's a problem with old type-fest and new typescript. This is a transitive dependency, specifically from ansi-escapes.

Due to latest version of that module not working for common.js - I'm stuck with the 4.x.x release.

So I force resolution with yarn to a later version: yarn set resolution type-fest@npm:^0.21.3 npm:^4.0.0

SBoudrias avatar Feb 25 '24 21:02 SBoudrias

Reporting the hardened mode issue here: https://github.com/yarnpkg/berry/issues/6141

SBoudrias avatar Feb 25 '24 21:02 SBoudrias