Inquirer.js icon indicating copy to clipboard operation
Inquirer.js copied to clipboard

Added error callback for when we fail in onEnd

Open mastrzyz opened this issue 2 years ago • 3 comments

mastrzyz avatar Jul 16 '23 22:07 mastrzyz

Hi @mastrzyz, thanks for sending a PR.

Could you help fixing the CI issues? And instead of an examples, adding a unit test would be more resilient - so it'd be awesome if you have time to add that in!

SBoudrias avatar Jul 28 '23 20:07 SBoudrias

Codecov Report

Patch coverage: 78.26% and project coverage change: +4.64% :tada:

Comparison is base (c4d0626) 72.29% compared to head (729a554) 76.94%. Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
+ Coverage   72.29%   76.94%   +4.64%     
==========================================
  Files          42       42              
  Lines        4083     4138      +55     
  Branches      665      735      +70     
==========================================
+ Hits         2952     3184     +232     
+ Misses        475      228     -247     
- Partials      656      726      +70     
Files Changed Coverage Δ
packages/inquirer/lib/prompts/confirm.js 80.76% <76.92%> (-1.05%) :arrow_down:
packages/inquirer/lib/prompts/input.js 83.92% <80.00%> (-2.06%) :arrow_down:

... and 8 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 04 '23 21:08 codecov[bot]

Hey @SBoudrias , fixed CI and added a UT!, let me know if this is fine or you would like one for each prompt.

mastrzyz avatar Aug 04 '23 22:08 mastrzyz