Inquirer.js icon indicating copy to clipboard operation
Inquirer.js copied to clipboard

feat(select): the help tip at first render

Open zonemeen opened this issue 2 years ago • 1 comments

The list type in [email protected] has a help-tip message at first render, while in @inquirer/[email protected] there is no.

1.The list type in [email protected]: list

2.The select type in @inquirer/[email protected]: select

zonemeen avatar Jul 26 '22 08:07 zonemeen

Codecov Report

Merging #1148 (9b27b61) into master (edc49ce) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1148   +/-   ##
=======================================
  Coverage   69.38%   69.38%           
=======================================
  Files           8        8           
  Lines         147      147           
  Branches       25       25           
=======================================
  Hits          102      102           
  Misses         27       27           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update edc49ce...9b27b61. Read the comment docs.

codecov[bot] avatar Jul 26 '22 08:07 codecov[bot]

Hey! Finally got some time to track down the bug! So it was a bit deep, but quite important, so really nice thing that is fixed now. useRef now works as expected, and I've merged this PR and my adjustment manually on the master branch.

Thanks for kicking this off - and surfacing a major bug!

SBoudrias avatar Aug 25 '22 03:08 SBoudrias

Thanks also for the work you do.

zonemeen avatar Aug 25 '22 06:08 zonemeen