ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

[sf][table]:Table header font is not correct in safari

Open QiuranHu opened this issue 1 year ago • 6 comments

Bug Description

Screenshot 2024-06-20 at 17 11 39 Table header font is not correct in safari

Affected Component

Table

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

Latest

Browser

Safari

Operating System

No response

Additional Context

No response

Organization

SAP SuccessFactors

Declaration

  • [X] I’m not disclosing any internal or sensitive information.

QiuranHu avatar Jun 20 '24 09:06 QiuranHu

Hello @aborjinik @DonkeyCo this is for the Table v2, could you have a look? Thank you!

ilhan007 avatar Jun 20 '24 09:06 ilhan007

Hi @ilhan007,

the table in question is the V1 Table see https://sap.github.io/ui5-webcomponents/components/Table/

Seems like there is a styling issue with the font-weight:

The table headers have the following font-weight in Safari: var(--ui5-v1-24-5_table_header_row_font_weight), which resolves to bold. When changing the font-weight to normal, the headers look correct.

Could you guys have a look here? Thanks!

DonkeyCo avatar Jun 21 '24 13:06 DonkeyCo

Hi @QiuranHu can give us more details about the environment

which MacOS and Safari do you use,

as on my MacOS Sonoma 14.5 and Safari 17.5, the column header texts are displayed fine:

Screenshot 2024-06-25 at 9 39 46

ilhan007 avatar Jun 25 '24 06:06 ilhan007

@ilhan007 Can you please add a screenshot of both safari and chrome display the same table side by side? I think we should have same visual effect in both safari and chrome because we should support both browsers. My mac os version is 14.5 and safari version is 17.5.

QiuranHu avatar Jun 25 '24 07:06 QiuranHu

Oh I see it now, sorry for the confusion, and @DonkeyCo also mentioned it above, on Safari the texts are bold.

On your screenshot the texts looked so blur and I thought this must be the issue, and it was definitely not the case when I checked the sample on Safari, but still there is a difference, they have to look like as on Chrome:

Screenshot 2024-06-25 at 10 49 35

On Safari we get this currently: Screenshot 2024-06-25 at 10 50 26

ilhan007 avatar Jun 25 '24 07:06 ilhan007

@ilhan007 Thank you for looking into this. I agree we have to make the table header looks the same on chrome and safari.

QiuranHu avatar Jun 25 '24 07:06 QiuranHu

Fixed the issue for version 1.24 with https://github.com/SAP/ui5-webcomponents/pull/9418 and it will be available with the next patch. For version 2.0 and table inside @ui5/webcomponents-compat is fixed with https://github.com/SAP/ui5-webcomponents/pull/9417

nnaydenow avatar Jul 09 '24 20:07 nnaydenow