ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

[DynamicSideContent]: aria-label for the side panel is meaningless and not customizable and missing aria-label for the main conent

Open yzy415 opened this issue 10 months ago • 2 comments

Bug Description

As shown below, the aria-label for the side panel is "Side Content" which is too generic and not customizable. We should support accepting the consumer-defined aria-lable for the side panel.

Besides, the aria-label for the main content is missed.

image

Affected Component

DynamicSideContent

Expected Behaviour

aria-label for the side panel should be customizable and we should also give the main content a customizable aria-label.

Isolated Example

No response

Steps to Reproduce

  1. go to ui5 DynamicSideContent documentation
  2. inspect the side content and main content

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.26.1

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Organization

SAP SF

Declaration

  • [X] I’m not disclosing any internal or sensitive information.

yzy415 avatar Apr 03 '24 07:04 yzy415

Hello @SAP/ui5-webcomponents-topic-b,

There is a feature request to provide an API to set custom labels on the side content area/contianer. Also, the main area/container seems to lack accessibility attributes (like role and aria-label). You can inspect the sample in the playground: https://sap.github.io/ui5-webcomponents/nightly/components/fiori/DynamicSideContent Could you please have a look?

Kind Regards, Dobrin

dobrinyonkov avatar Apr 03 '24 10:04 dobrinyonkov

Hi @yzy415 ,

The request is now internally logged as FIORITECHE1-8187, and we'll promptly notify you once it's been addressed. Thanks & Regards,

Nikolay Hristov

NHristov-sap avatar Apr 26 '24 13:04 NHristov-sap