ui5-webcomponents
ui5-webcomponents copied to clipboard
SAP
refactor(ui5-menu): adjust menu and sub-menu creation
-
The ui5-menu elements used for sub-menus are created only once and are being reused afterwards. They are no longer destroyed on close. This contributes to lowering the count of the slow DOM manipulation operations.
-
There is now no differentiation between mobile and desktop device in regards to the display mechanism. In both cases we rely on the template to do the job as the components used for composition like ui5-list and ui5-responsive-popover do comply with the device.
Fixes: #7767 Fixes: #7423 Fixes: #6761
One from me: on mobile view, there is a focus on disabled items, please check.
One from me: on mobile view, there is a focus on disabled items, please check.
The focus appears on an actual mobile device on item press. The same behavior was also reproducible before this change
and also this behavior actually comes from the ui5-list component. It could be reproduced there if the ui5-item-click
event gets prevented at application side.
Two things: Now when hovering with mouse on a menu with busy indicator, the focus goes to busy indicator. We have arrow back in main menu on mobile view.
Those two cases are now handled properly.
I am not able to select the first item.(Space, Enter or Mouse click). Is that something with the sample or an issue?
The default behavior for the menu item is prevented at application level. I've improved the tooltip and menu item texts, in order to give detail about the item selection as we've discussed.