ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

Table: TableColumn with popin is not selected

Open mrCherry97 opened this issue 1 year ago • 11 comments

Describe the bug

As a user, I want to make one column a popin, and after selecting the row I want to have this popin also marked as selected.

Isolated Example

No response

Reproduction steps

  1. Create Table
  2. Add TableColumn with popin prop
  3. Add TableRow and provide selected prop
  4. Check UI

Expected Behaviour

All row is selected like this (my requirement from UXes): image

Screenshots or Videos

Table looks like this: image

and after clicking on one of the row column layout is opened, but TableColumn with popin is not selected. image

UI5 Web Components for React Version

"@ui5/webcomponents-react": "~1.23.0",

UI5 Web Components Version

"@ui5/webcomponents": "^1.20.0",

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Relevant log output

No response

Declaration

  • [X] I’m not disclosing any internal or sensitive information.

mrCherry97 avatar Jan 30 '24 14:01 mrCherry97

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

Lukas742 avatar Jan 30 '24 14:01 Lukas742

Hello @SAP/ui5-webcomponents-topic-rl it's about the ui5-table, and the fact that the popped in content does not have the propert selection background when the table row (that it's associated to) is selected

ilhan007 avatar Jan 30 '24 14:01 ilhan007

Possible steps:

  1. Open the pop-in storybook sample https://sap.github.io/ui5-webcomponents/playground/?path=/story/main-table--popin-display-inline

  2. Choose Multiple selection mode

  3. Shrink a bit (if needed) to ensure you have pop-in column

  4. Select the first row

  5. Observe the result (the selection is not covering the pop-in content) Screenshot 2024-01-30 at 16 20 04

ilhan007 avatar Jan 30 '24 14:01 ilhan007

hi, @ilhan007 @Lukas742 have you got any timebox planned for fixing this?

Best regards, Mateusz

mrCherry97 avatar Feb 06 '24 12:02 mrCherry97

Hi @mrCherry97 the issue has been dispatched to the development team. Usually bugs don't have clear milestone, the team work on the open bugs given the priority, taking into account thing like - is it functional, is it only visual, is it security, is it accessibility issue, information of the impact/urgency within the issue description, the issue creation date, etc.

Please elaborate on the importance of the issue, so that the team can prioritise it. Having said this, I will let @hristop to answer your question as the current owner.

ilhan007 avatar Feb 06 '24 14:02 ilhan007

Thanks for your fast response @ilhan007, for us, this topic is crucial, because we are planning to merge our changes around next week or 2 weeks, and it will be lovely if this will be fixed because it's very problematic and misleading for the user with a current view: image for example here, the Labels column looks like it's not connected to selected resource, so from our perspective, this bug has a big impact on our app. If it's possible I need a +- timebox, because I need to plan if we want to continue working on this topic, or if we need to wait more time to release this (it would be lovely if we don't need to postpone the release of this feature). Thanks!

mrCherry97 avatar Feb 06 '24 14:02 mrCherry97

Hi @mrCherry97 ,

We will try to find some time to look into the issue next week, but as it may need some sort of restructuring / refactoring of the table rows, I can't guarantee that this will be a quick fix.

Best Regards, Hristo

hristop avatar Feb 09 '24 13:02 hristop

Hi @hristop

One more thing to this issue, hover also should work on whole row, because currently it looks like this and this is very misleading for the user: image

Thanks in advance! Best regards Mateusz

mrCherry97 avatar Feb 15 '24 13:02 mrCherry97

Dear reporter,

Merging: https://github.com/SAP/ui5-webcomponents/pull/8372

Will fix the highlighting after selection issue. The rest will be part of the refactoring of the table component.

Regards! Martin

MapTo0 avatar Feb 29 '24 13:02 MapTo0

Hi @MapTo0 when can we expect a release of this fix, and when you plan to refactor Table component?

Regards! Mateusz

mrCherry97 avatar Mar 05 '24 13:03 mrCherry97

Hi @mrCherry97 ,

The next release should happen around the end of March. As to the second question, I will leave the answer to the Tables team as they are currently in the process of developing the new web components table.

Best Regards, Hristo

hristop avatar Mar 05 '24 13:03 hristop