ui5-webcomponents
ui5-webcomponents copied to clipboard
Table: TableColumn with popin is not selected
Describe the bug
As a user, I want to make one column a popin, and after selecting the row I want to have this popin also marked as selected.
Isolated Example
No response
Reproduction steps
- Create Table
- Add
TableColumn
with popin prop - Add
TableRow
and provide selected prop - Check UI
Expected Behaviour
All row is selected like this (my requirement from UXes):
Screenshots or Videos
Table looks like this:
and after clicking on one of the row column layout is opened, but TableColumn
with popin is not selected.
UI5 Web Components for React Version
"@ui5/webcomponents-react": "~1.23.0",
UI5 Web Components Version
"@ui5/webcomponents": "^1.20.0",
Browser
Chrome
Operating System
MacOS
Additional Context
No response
Relevant log output
No response
Declaration
- [X] I’m not disclosing any internal or sensitive information.
Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.
Hello @SAP/ui5-webcomponents-topic-rl it's about the ui5-table, and the fact that the popped in content does not have the propert selection background when the table row (that it's associated to) is selected
Possible steps:
-
Open the pop-in storybook sample https://sap.github.io/ui5-webcomponents/playground/?path=/story/main-table--popin-display-inline
-
Choose Multiple selection mode
-
Shrink a bit (if needed) to ensure you have pop-in column
-
Select the first row
-
Observe the result (the selection is not covering the pop-in content)
hi, @ilhan007 @Lukas742 have you got any timebox planned for fixing this?
Best regards, Mateusz
Hi @mrCherry97 the issue has been dispatched to the development team. Usually bugs don't have clear milestone, the team work on the open bugs given the priority, taking into account thing like - is it functional, is it only visual, is it security, is it accessibility issue, information of the impact/urgency within the issue description, the issue creation date, etc.
Please elaborate on the importance of the issue, so that the team can prioritise it. Having said this, I will let @hristop to answer your question as the current owner.
Thanks for your fast response @ilhan007,
for us, this topic is crucial, because we are planning to merge our changes around next week or 2 weeks, and it will be lovely if this will be fixed because it's very problematic and misleading for the user with a current view:
for example here, the
Labels
column looks like it's not connected to selected resource, so from our perspective, this bug has a big impact on our app. If it's possible I need a +- timebox, because I need to plan if we want to continue working on this topic, or if we need to wait more time to release this (it would be lovely if we don't need to postpone the release of this feature).
Thanks!
Hi @mrCherry97 ,
We will try to find some time to look into the issue next week, but as it may need some sort of restructuring / refactoring of the table rows, I can't guarantee that this will be a quick fix.
Best Regards, Hristo
Hi @hristop
One more thing to this issue, hover
also should work on whole row, because currently it looks like this and this is very misleading for the user:
Thanks in advance! Best regards Mateusz
Dear reporter,
Merging: https://github.com/SAP/ui5-webcomponents/pull/8372
Will fix the highlighting after selection issue. The rest will be part of the refactoring of the table component.
Regards! Martin
Hi @MapTo0 when can we expect a release of this fix, and when you plan to refactor Table component?
Regards! Mateusz
Hi @mrCherry97 ,
The next release should happen around the end of March. As to the second question, I will leave the answer to the Tables team as they are currently in the process of developing the new web components table.
Best Regards, Hristo