ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

feat(ui5-dynamic-page): introduce new component

Open dobrinyonkov opened this issue 1 year ago • 4 comments

New ui5-dynamic-page component.

The component is a composition of the following subcomponents:

  • DynamicPageTitle - holds the most top area of DynamicPage (breadcrumbs, actions, etc.)
  • DynamicPageHeader - a container displayed between the title area and the content that allows generic contet.
  • DynamicPageHeaderActions (private) - abstraction of the expand and pin header buttons, allowing for better reusability when state is expanded or collpased.

dobrinyonkov avatar Nov 22 '23 09:11 dobrinyonkov

@ilhan007, Thanks for the review. I added a new commit with the following major changes:

  • 3 new events are fired by the dynamic page, names can be discussed: -- expand-click (preventable) - fires when the expand or the collapse arrow buttons are clicked -- pin-click (preventable) - fired when the pin or unpin button is clicked -- title-click (preventable) - fired when the title is clicked to toggle the expanded state

  • slot footer is now named footerArea to be consistent witht titleArea, headerArea -- unfortunately the term "title" is reserved for the HTML's title attribute and it may create conflicts/impacts with accessibility or typescript features. Still, other namings can be discussed.

dobrinyonkov avatar Feb 13 '24 10:02 dobrinyonkov

Afterwards it should be pointed to release-2.0 (or to main, but after 1.24 is released).

ilhan007 avatar Mar 25 '24 10:03 ilhan007

I was thinking if it’s a good idea to provide parts for the main areas since they have responsive paddings by default

nnaydenow avatar May 11 '24 13:05 nnaydenow

provide parts for the main areas

We had such requirements for the TabContainer in the past - it also implements responsive paddings, but still consumers wanted to clear them for some reason. So I think - it's ok to include them.

ilhan007 avatar May 13 '24 09:05 ilhan007