ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard
verified publisher icon SAP

fix(theming): add custom theme support for external CSS

Open nnaydenow opened this issue 3 years ago • 0 comments

Now, we support two scenarios where OpenUI5/ SAPUI5 is detected and stand-alone web components project.

If OpenUI5Support is feature is registered, we leave previous implementation where sap.ui.core CSS variables should be imported (data-sap-ui-xx-cssVariables should be used in that scenario). CSS variables will be loaded from url + UI5/sap/ui/core/themes/custom_theme/css_variables.css

If OpenUI5Support feature is not registered we load custom CSS variables and rerender all components. CSS variables will be loaded from url + Base/baseLib/custom_theme/css_variables.css

Like in OpenUI5 when CSS variables are loaded from different origin than current, meta tag with allowed theme roots should be used (sap-allowedThemeOrigins).

  • [ ] Checks for theme origin
  • [ ] Should we extend the theme origin with UI5?

nnaydenow avatar Oct 05 '22 08:10 nnaydenow