ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

openedRegistry to be assigned globally to prevent multiple esc keyboard events from firing.

Open lormanlau opened this issue 2 years ago • 2 comments

Feature Request Description

A clear and concise description of what feature is missing. Is your feature request related to a problem? Please describe.

The keyboard esc key event is closing the ui5 dialog while also inside of an inner ui5 webcomponent which also has a esc key event while 2 different instances are active. (EX: Date Picker inside of Dialog with 2 different instances of ui5 webcomponents import)

Proposed Solution

A clear and concise description of the solution you would like to have.

Have the openedRegistry array globally assigned so that multiple instances of ui5 webcomponents use the same queue. https://github.com/SAP/ui5-webcomponents/blob/205d8e481859bd7fc5f15693956f352664be7d24/packages/main/src/popup-utils/OpenedPopupsRegistry.js#L3

Proposed Alternatives

A clear and concise description of any alternative solutions or features you've considered.

Additional Context

Add other context or screenshots related to the feature request here.

We are trying to create multiple modular custom components which imports multiple instances of ui5 webcomponents library.

Priority

  • [ ] Low
  • [x] Medium
  • [ ] High
  • [ ] Very High

A clear and concise description of the impact/urgency of the required feature.

Stakeholder Info (if applicable)

  • Organization: SAP Success Factors
  • Business impact: Medium

lormanlau avatar Aug 04 '22 17:08 lormanlau

Hey @lormanlau

Correct me if I am wrong but you are using two different instance of ui5-webcomponents in a single project using the scoping feature, right?

The issue is that the popup registry is not common between instances.

Regards, Martin

MapTo0 avatar Aug 05 '22 13:08 MapTo0

Hi @MapTo0

Yes the popup registry is not common between the instances. We are actually using multiple instance of ui5-webcomponents to try and make our code more modular.

Thanks, Lorman

lormanlau avatar Aug 09 '22 22:08 lormanlau

Hello @lormanlau isn't this issue duplicate of https://github.com/SAP/ui5-webcomponents/issues/5634. There we have more comments, so it's better use the other one. I will close this one as duplicate if that's ok for you? Please leave a comment if I am missing something and this is a different issue.

Thanks, ilhan

ilhan007 avatar Aug 30 '22 12:08 ilhan007