ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

FilterSelectionDialog: OnGrow is not always called

Open Saschl opened this issue 3 years ago • 1 comments

Describe the bug When using ListGrowingMode.Scroll with the FilterSelectionDialog, the "growing" handler is not always called. It seems like it is dependent on the window size of the browser.

Isolated Example https://codesandbox.io/s/relaxed-moon-c5qsfb?file=/src/App.js&resolutionWidth=1410&resolutionHeight=1220

To Reproduce Steps to reproduce the behavior:

  1. Go to the sample and open the developer mode and console.
  2. Scroll down to the end of the list
  3. No console output should be triggered when scrolling to the end of the list
  4. Change the screen size in codesandbox to 1410x1230 and scroll down again.
  5. "Growing" should be output to the console

Expected behavior The event should also be fired when reaching the end of the list and not depend on screen size.

Screenshots No event triggered: image

Resolution changed, event works: image

UI5 Web Components for React Information

   "@ui5/webcomponents": "~1.5.0",

   "@ui5/webcomponents-fiori": "~1.5.0",

   "@ui5/webcomponents-react": "^0.26.0"

Operating System: Windows 10 Browser: Edge 103.0.1264.62

Saschl avatar Jul 22 '22 12:07 Saschl

Thanks for reporting! As the root cause of this issue seems to be caused by the UI5 Dialog Web Component, I'll forward this issue to the UI5 Web Components repository.

@ UI5 Web Components Team: Here you can find a codesandbox using plain UI5 Web Components: https://codesandbox.io/s/reverent-jones-0yp511?file=/src/App.js:438-444&resolutionWidth=1000&resolutionHeight=1220

You can follow the same instructions as in the issue above.

MarcusNotheis avatar Aug 02 '22 16:08 MarcusNotheis

Hello, for me, when using plain UI5 WebComponents the event is fired every time, no matter of the resolution. I was only able to reproduce it in the author's React example.

ndeshev avatar Aug 29 '22 14:08 ndeshev