[SF][A11Y][Button] some icon only button svg with role="img" don't have an aria-label

[sfsf-xweb-sh]

Bug Description

some icon only button svg with role="img" don't have an aria-label

Expected Behavior

icon only button svg with role="img" should have an aria-label.

Steps to Reproduce

1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Button/
2. see the result with chrome dev tool

Context

• UI5 Web Components version: 1.6.0
• OS/Platform: all
• Browser: all
• Affected component: ui5-button

Log Output / Stack Trace / Screenshots

{...}

Priority

• [ ] Low
• [x] Medium
• [ ] High
• [ ] Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

• Breaks entire application or system - High or Very High
• Accessibility issue - Medium or High
• Functional issue - Medium or High
• Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

• Organization: {SF}
• Business impact: {Medium}

[MapTo0]

Dear @SAP/ui5-webcomponents-topic-b

We discusses with Boyan, that you have done some work on that topic with that change: https://github.com/SAP/ui5-webcomponents/pull/5592

Could you please check if it satisfies the requirement here.

Regards, Martin

[unazko]

Hello @sfsf-xweb-sh,

There is the following component enhancement: https://github.com/SAP/ui5-webcomponents/issues/5733 With it we'll apply the default tooltip (coming from the inner icon) to the ui5-button component directly. This will result in no AXE reports in the described use case even if there is no tooltip property provided application side, as the inner ui5-icon will have role "presentation".

Currently the internal ui5-icon tooltip is displayed for the ui5-button if no tooltip property is set. Some ui5-icon's do not provide a default tooltip and so is the icon-onlyui5-button, which is uses such icon. There are also cases when the default icon tooltip doesn't describe the button's function well enough. In such cases there should be a tooltip property set at application side.

"As per UX guidelines all icon-only button instances should have a tooltip. The tooltip attribute should be set at application side for all cases when there is no default tooltip coming from the inner ui5-icon element."

Best Regards, Boyan Rakilovski