ui5-webcomponents
ui5-webcomponents copied to clipboard
fix(ui5-view-settings-dialog): update setConfirmedSettings param string type from String to Object and description sample code
fix(ui5-view-settings-dialog): update setConfirmedSettings param strong type from String to Object and description sample code
setConfirmedSettings' setting type should be an Object
Fixes #5222
https://github.com/SAP/ui5-webcomponents-react/pull/3272
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Hi @NHristov-sap - could you please review at your earliest convenience? Thanks!
Hi @tsanislavgatev - could you please review one more time? Thanks!
@tsanislavgatev @NHristov-sap - could you guys please approve running workflows?
@rchrdchn could you please rebase from main, I have updated chrome driver and the tests should pass
@rchrdchn could you please rebase from main, I have updated chrome driver and the tests should pass
Done - hoping I did it correctly 🙂