ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

fix(ui5-view-settings-dialog): update setConfirmedSettings param string type from String to Object and description sample code

Open rchrdchn opened this issue 2 years ago • 3 comments

fix(ui5-view-settings-dialog): update setConfirmedSettings param strong type from String to Object and description sample code

setConfirmedSettings' setting type should be an Object

Fixes #5222

https://github.com/SAP/ui5-webcomponents-react/pull/3272

rchrdchn avatar Jul 19 '22 21:07 rchrdchn

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Jul 19 '22 21:07 cla-assistant[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Jul 19 '22 21:07 cla-assistant[bot]

Hi @NHristov-sap - could you please review at your earliest convenience? Thanks!

rchrdchn avatar Aug 02 '22 18:08 rchrdchn

Hi @tsanislavgatev - could you please review one more time? Thanks!

rchrdchn avatar Aug 17 '22 21:08 rchrdchn

@tsanislavgatev @NHristov-sap - could you guys please approve running workflows?

rchrdchn avatar Aug 19 '22 17:08 rchrdchn

@rchrdchn could you please rebase from main, I have updated chrome driver and the tests should pass

pskelin avatar Aug 19 '22 19:08 pskelin

@rchrdchn could you please rebase from main, I have updated chrome driver and the tests should pass

Done - hoping I did it correctly 🙂

rchrdchn avatar Aug 19 '22 20:08 rchrdchn