ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

Published 20 hours ago • verified publisher icon SAP

[SF][ViewSettingsDialog] - setConfirmedSettings lifecycle

Open rchrdchn opened this issue 2 years ago • 2 comments

Bug Description

ViewSettingsDialog component doesn't get confirmed settings state from setConfirmedSettings on the first click/try.

Expected Behavior

ViewSettingsDialog component should get confirmed settings state from setConfirmedSettings on the first click/try.

Steps to Reproduce

  1. Go to 'https://codesandbox.io/s/ui5-webcomponents-forked-0y7rpv?file=/src/index.js'
  2. Click Open dialog button
  3. Sort Order: Descending AND Sort By: Name
  4. Click OK button
  5. Click on link: Go to page (/page)
  6. Click on link: Go back (/index)
  7. Click Open dialog button
  8. Expected: Sort Order: Descending AND Sort By: Name
  9. Actual: Initial Sort Order and Sort By
  10. Close and Open dialog again
  11. Sorting is --> Sort Order: Descending AND Sort By: Name
  12. Expected: Sort Order and Sort By to be coming from setConfirmedSettings object after going back from /page to /index

Isolated Example

https://codesandbox.io/s/ui5-webcomponents-forked-0y7rpv?file=/src/index.js

Priority

  • [ ] Low
  • [x] Medium
  • [ ] High
  • [ ] Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

  • Functional issue - Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

  • Organization: SuccessFactors

Ref: https://github.com/SAP/ui5-webcomponents/issues/4896 PR: https://github.com/SAP/ui5-webcomponents/pull/5222/files

rchrdchn avatar Jul 19 '22 21:07 rchrdchn

Hello @SAP/ui5-webcomponents-topic-b , take a look of this feature request.

Todor-ads avatar Jul 22 '22 07:07 Todor-ads

Hi team - following up on this issue. Any news?

rchrdchn avatar Aug 02 '22 18:08 rchrdchn

Hi team - following up on this issue. Any updates?

rchrdchn avatar Aug 17 '22 21:08 rchrdchn

Hello @rchrdchn, Sorry for the late reply. We are working on fix the reported issue and we will update you with our findings as soon as possible.

Best Regards, Todor

Todor-ads avatar Aug 18 '22 09:08 Todor-ads

@Todor-ads thanks for the note, any progress on this issue?

jatinthaker avatar Aug 23 '22 21:08 jatinthaker

Also @Todor-ads, isn't the issue a defect in https://github.com/SAP/ui5-webcomponents/issues/4896? And if so, then the feature request label that is currently on this issue is incorrect.

stoehr avatar Aug 28 '22 05:08 stoehr

Hello colleagues,

This is a feature request. In a comment of mine in the issue you've shared.(https://github.com/SAP/ui5-webcomponents/issues/4896). I spoke about the lifecycle that we will support it after the first opening, this is because of the lifecycle of the event. You have agreed with it, but if this does not work as you expected, we can have a research and try to alter the current behaviour and implement something in addition to it, so it can be matching your expectations.

tsanislavgatev avatar Aug 30 '22 06:08 tsanislavgatev

hi @tsanislavgatev - could you share the status on this issue, please?

rchrdchn avatar Nov 21 '22 16:11 rchrdchn

Hi guys - following up here. Any news?

rchrdchn avatar Jan 18 '23 18:01 rchrdchn

Hi @Todor-ads, I am also facing the same problem. Is there any fix scheduled for this problem? And if yes, what would be the expected timeline for the release of the fix?

akshilverma avatar Feb 20 '23 07:02 akshilverma

Following up on this issue @petyabegovska @Todor-ads - any advancements on this? It's been opened for almost a year.

rchrdchn avatar Jul 05 '23 12:07 rchrdchn

Hello @rchrdchn ,

Can you please give us exact explanation on what are your expectations and your usecase so we can add functionality that would help you. After your explanation we will focus on the specific behaviour that you request to make the implementation.

Please elaborate on this in this issue.

Best Regards, Tsanislav

tsanislavgatev avatar Jul 06 '23 12:07 tsanislavgatev

As there is no answer in the last 6 months, I am closing this issue.

tsanislavgatev avatar Feb 06 '24 13:02 tsanislavgatev

Hi @tsanislavgatev - apologies for missing your previous message.

As mentioned above in the "Steps to Reproduce" section of the ticket, we are expecting the component to keep the state for Sort Order and Sort By after navigating to a different page and going back to the page where the ViewSettingsDialog is.

You can reproduce it with these steps below:

  • Go to 'https://codesandbox.io/s/ui5-webcomponents-forked-0y7rpv?file=/src/index.js'
  • Click Open dialog button
  • Sort Order: Descending AND Sort By: Name
  • Click OK button
  • Click on link: Go to page (/page)
  • Click on link: Go back (/index)
  • Click Open dialog button
  • Expected: Sort Order: Descending AND Sort By: Name
  • Actual: Initial Sort Order and Sort By
  • Close and Open dialog again
  • Sorting is --> Sort Order: Descending AND Sort By: Name
  • Expected: Sort Order and Sort By to be coming from setConfirmedSettings object after going back from /page to /index

rchrdchn avatar Feb 07 '24 21:02 rchrdchn