ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

ui5-button text shadow in high contrast theme

Open ee92 opened this issue 3 years ago • 1 comments

Bug Description

When hovered the ui5-button text has a text-shadow in high contrast themes, which is not there in UI5. UI5 Screen Shot 2022-06-27 at 11 14 05 AM ui5-webcomponents Screen Shot 2022-06-27 at 11 14 13 AM

Expected Behavior

Expect the ui5-button to have the same style as the UI5 button, with no text-shadow.

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Button/?sap-ui-theme=sap_belize_hcw
  2. Hover the first button
  3. Notice the text-shadow
  4. Compare to https://sapui5.hana.ondemand.com/#/entity/sap.m.Button/sample/sap.m.sample.Button (select Hight Contrast White theme) which has no text-shadow when hovered.

Context

  • UI5 Web Components version: 1.4.0
  • Affected component: ui5-button

Priority

  • [ ] Low
  • [x] Medium
  • [ ] High
  • [ ] Very High

Stakeholder Info

  • Organization: SuccessFactors

ee92 avatar Jun 27 '22 18:06 ee92

Hi @SAP/ui5-webcomponents-topic-b ,

Could you please check the issue? There is visual issue where text has shadow around it in all contrast themes except the ones for horizon theme.

Regards, Nayden

nnaydenow avatar Jun 28 '22 07:06 nnaydenow

Hi @ilhan007 , This issue also exists in theme sap_fiori_3_hcw https://sap.github.io/ui5-webcomponents/playground/components/Button/?sap-ui-theme=sap_fiori_3_hcw, please also fix it.

For sap_fiori_3_hcb and sap_belize_hcb themes, there also has a text-shadow.

GongRichard avatar Aug 26 '22 10:08 GongRichard