ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

Feature Request - Required ShortcutText property in MenuItem

Open ShivamGuptaSap opened this issue 2 years ago • 6 comments

Feature Request Description

In MenuItem we need a shortcutText property so that we can add shortcut texts along with the menu Item.

Proposed Solution

Just like we have that property in Orca-React-UI

Proposed Alternatives

Additional Context

Kindly refer to the screenshots:

Its Purpose: image

In Orca-React-UI they offer this: image

Priority

  • [ ] Low
  • [ ] Medium
  • [ ] High
  • [x] Very High

As we are in the middle of migrating the whole project "SAC Lite-Viewer" from Orca-React-UI to UI5-WebComponent for React. So we will be needing this feature on urgent basis.

Stakeholder Info (if applicable)

  • Organization: { SAP }
  • Business impact: {...}

ShivamGuptaSap avatar Jun 16 '22 09:06 ShivamGuptaSap

Hello @SAP/ui5-webcomponents-topic-b ,

Take a look of this feature request for shortcutText property.

Best regards, Petar

dimovpetar avatar Jun 16 '22 12:06 dimovpetar

Hello @petyabegovska! I just wanted to check in to see if you'd had a chance to look at this one yet. Does it seem like something that might be possible?

scameron avatar Jun 28 '22 07:06 scameron

Hi @scameron,

Yes, it is possible technically, but I am waiting also for the UX/VD feedback.

One clarification question on your use case: Do you need to hide the text on mobile? (as there are no shortcuts there).

Best regards, Petya

petyabegovska avatar Jun 29 '22 09:06 petyabegovska

Sorry for the delay, @petyabegovska, I needed to double check with the team. For our specific need, we will not be using the MenuItem control on mobile so we don't have any special requirement there.

But in general, I think what you're saying sounds correct, that it should probably be hideable for cases where shortcut keys don't make sense. But our particular use case doesn't require this.

scameron avatar Jun 30 '22 10:06 scameron

Hi @petyabegovska , were you able to get any feedback from UX/VD team?

ddrana avatar Jul 28 '22 04:07 ddrana

Hi @petyabegovska, just wanted to check in about this one again. Does it seems like something that could be added to the component?

scameron avatar Aug 08 '22 14:08 scameron

Issue resolved with https://github.com/SAP/ui5-webcomponents/pull/5867 and released with 1.8.0

ilhan007 avatar Oct 03 '22 15:10 ilhan007