[Button]: Redundant accessible information
Describe the bug
if we set tooltip, accessible name, it will read as delete delete the item button delete the item, which is redundant.
Isolated Example
Reproduction steps
...
Expected Behaviour
No response
Screenshots or Videos
No response
UI5 Web Components for React Version
2.14
UI5 Web Components Version
2.14
Browser
Edge
Operating System
No response
Additional Context
No response
Relevant log output
Organization
No response
Declaration
- [x] I’m not disclosing any internal or sensitive information.
Hi @wilson-xu-sap,
modern screen readers should prefer aria-label (accessibleName) over title (tooltip) if both are present (unless configured otherwise, e.g. via verbosity settings). Still, I’ll transfer this issue to the UI5/webcomponents repo, so the responsible team can check.
To help them process the issue faster, please provide the screen reader and version you're using.
Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!
Hi @Lukas742 Yes, so why does the button have duplicate verbs?
@wilson-xu-sap The text of the button is currently being added to the aria-label of the button. I explained this in the other issue you opened.
This shouldn’t affect the title (tooltip) announcement, though - for that, it’s easier for us to help you if you provide the Screen Reader and which version you’re using.
As I’m not involved in the development of the ui5/webcomponents libraries, and only one of the maintainers of ui5/webcomponents-react, the colleagues responsible for ui5/webcomponents should decide how to proceed with this issue. That’s why I transferred it.
Yes, your understanding is correct. I am asking why the accessible behavior changes and now it does not look correct.
Hello @UI5/ui5-team-ctr-bal ,
This issue is similar to https://github.com/UI5/webcomponents/pull/12473, but this time it involves tooltip property usage.
I have tested similar button in OpenUI5 and the speech output is the same as the component's - both tooltip and ariaLabelledBy are announced. Anyways, sending it to your team for final statement.
sap.ui.require(["sap/m/Button", "sap/ui/core/InvisibleText"], (Button, InvisibleText) => {
new InvisibleText("invisText", {
text: "delete the item"
}).placeAt("content");
new Button({
tooltip: "delete the item",
text: "Delete",
press() {
alert("Hello");
},
ariaLabelledBy: "invisText"
}).placeAt("content");
});
Best regards, Petar
Hello colleagues, Thought this issue was introduced with the following PR, but from my testing it seems that is not the case. I'm un-assigning my self as I'll be out of office the next two weeks.
Best regards, Boyan