ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard
verified publisher icon SAP

[ui5-link]: "click" event propagates to dialog close button

Open ee92 opened this issue 6 months ago • 1 comments

Bug Description

Opening a dialog using a ui5-link by keyboard causes the first focused element in the dialog to also be triggered

Affected Component

ui5-link, ui5-button, ui5-dialog

Expected Behaviour

Expect it to work the same as the ui5-button for opening a dialog. The event should not be propagated to the first focused element of the dialog.

Isolated Example

https://sap.github.io/ui5-webcomponents/play/#eyJpbmRleC5odG1sIjp7Im5hbWUiOiJpbmRleC5odG1sIiwiY29udGVudCI6IjwhLS0gcGxheWdyb3VuZC1mb2xkIC0tPlxuPCFET0NUWVBFIGh0bWw-XG48aHRtbCBsYW5nPVwiZW5cIj5cblxuXG5cbjxoZWFkPlxuICAgIFxuICAgIDxzdHlsZT5cbiAgICAgICo6bm90KDpkZWZpbmVkKSB7XG4gICAgICAgIGRpc3BsYXk6IG5vbmU7XG4gICAgICB9XG5cbiAgICBodG1sIHtcbiAgICAgIGZvcmNlZC1jb2xvci1hZGp1c3Q6IG5vbmU7XG4gICAgfVxuICAgIDwvc3R5bGU-XG5cbiAgICBcbiAgICA8c3R5bGU-XG4gICAgICAqOm5vdCg6ZGVmaW5lZCkge1xuICAgICAgICBkaXNwbGF5OiBub25lO1xuICAgICAgfVxuXG4gICAgaHRtbCB7XG4gICAgICBmb3JjZWQtY29sb3ItYWRqdXN0OiBub25lO1xuICAgIH1cbiAgICA8L3N0eWxlPlxuXG4gICAgPG1ldGEgY2hhcnNldD1cIlVURi04XCI-XG4gICAgPG1ldGEgbmFtZT1cInZpZXdwb3J0XCIgY29udGVudD1cIndpZHRoPWRldmljZS13aWR0aCwgaW5pdGlhbC1zY2FsZT0xLjBcIj5cbiAgICA8dGl0bGU-U2FtcGxlPC90aXRsZT5cbiAgICA8bGluayByZWw9XCJzdHlsZXNoZWV0XCIgaHJlZj1cIi4vbWFpbi5jc3NcIj5cbjwvaGVhZD5cblxuPGJvZHkgc3R5bGU9XCJiYWNrZ3JvdW5kLWNvbG9yOiB2YXIoLS1zYXBCYWNrZ3JvdW5kQ29sb3IpOyBoZWlnaHQ6IDQ1MHB4O1wiPlxuICAgIDwhLS0gcGxheWdyb3VuZC1mb2xkLWVuZCAtLT5cblxuPHA-VXNlIGtleWJvYXJkIHRvIG9wZW4gdGhlIGRpYWxvZyB1c2luZyB0aGUgbGluayBhbmQgdGhlIGJ1dHRvbjwvcD5cbjxwPk5vdGljZSB0aGUgZGlhbG9nIGlzIGltbWVkaWF0ZWx5IGNsb3NlZCB3aGVuIG9wZW5lZCBieSBsaW5rIHVzaW5nIFwiRW50ZXJcIiBrZXkgKGV2ZW50IGxpa2VseSBwcm9wYWdhdGVkIHRvIGRpYWxvZyBjbG9zZSBidXR0b24pPC9wPiAgICBcblxuPHVpNS1saW5rIGlkPVwiZGlhbG9nT3BlbmVyTGlua1wiPk9wZW4gRGlhbG9nPC91aTUtbGluaz5cbiAgICA8YnIvPjxici8-XG4gICAgPHVpNS1idXR0b24gaWQ9XCJkaWFsb2dPcGVuZXJCdG5cIj5PcGVuIERpYWxvZzwvdWk1LWJ1dHRvbj5cblxuICAgIDx1aTUtZGlhbG9nIGlkPVwiZGlhbG9nXCI-XG4gICAgICAgIDx1aTUtYmFyIHNsb3Q9XCJoZWFkZXJcIiBkZXNpZ249XCJIZWFkZXJcIj5cbiAgICAgICAgICAgIDx1aTUtdGl0bGUgbGV2ZWw9XCJINVwiIHNsb3Q9XCJzdGFydENvbnRlbnRcIj5CYXIgdXNlZCBpbiBIZWFkZXIgYW5kIEZvb3RlcjwvdWk1LXRpdGxlPlxuICAgICAgICAgICAgPHVpNS1idXR0b24gY2xhc3M9XCJkaWFsb2dDbG9zZXJcIiBkZXNpZ249XCJUcmFuc3BhcmVudFwiIGlkPVwiY2xvc2VEaWFsb2dCdXR0b25cIiBzbG90PVwiZW5kQ29udGVudFwiXG4gICAgICAgICAgICAgICAgaWNvbj1cImRlY2xpbmVcIj48L3VpNS1idXR0b24-XG4gICAgICAgIDwvdWk1LWJhcj5cbiAgICAgICAgPHA-QWRkaW5nIHN0eWxlcyBmb3IgdGhlIHBhcnRzIHRvIHJlbW92ZSB0aGUgZGVmYXVsdCBEaWFsb2cncyBwYWRkaW5ncyB3aGVuIHVpNS1iYXIgaXMgdXNlZCBpbnNpZGUgSGVhZGVyIGFuZFxuICAgICAgICAgICAgRm9vdGVyPC9wPlxuICAgICAgICA8dWk1LWJhciBzbG90PVwiZm9vdGVyXCIgZGVzaWduPVwiRm9vdGVyXCI-XG4gICAgICAgICAgICA8dWk1LWJ1dHRvbiBjbGFzcz1cImRpYWxvZ0Nsb3NlclwiIGRlc2lnbj1cIkVtcGhhc2l6ZWRcIiBzbG90PVwiZW5kQ29udGVudFwiXG4gICAgICAgICAgICAgICAgc3R5bGU9XCJtaW4td2lkdGg6IDRyZW07XCI-T0s8L3VpNS1idXR0b24-XG4gICAgICAgIDwvdWk1LWJhcj5cbiAgICA8L3VpNS1kaWFsb2c-XG4gICAgPCEtLSBwbGF5Z3JvdW5kLWZvbGQgLS0-XG4gICAgPHNjcmlwdCB0eXBlPVwibW9kdWxlXCIgc3JjPVwibWFpbi5qc1wiPjwvc2NyaXB0PlxuPC9ib2R5PlxuXG48L2h0bWw-XG48IS0tIHBsYXlncm91bmQtZm9sZC1lbmQgLS0-XG4ifSwibWFpbi5qcyI6eyJuYW1lIjoibWFpbi5qcyIsImNvbnRlbnQiOiIvKiBwbGF5Z3JvdW5kLWhpZGUgKi9cbmltcG9ydCBcIi4vcGxheWdyb3VuZC1zdXBwb3J0LmpzXCI7XG4vKiBwbGF5Z3JvdW5kLWhpZGUtZW5kICovXG5pbXBvcnQgXCJAdWk1L3dlYmNvbXBvbmVudHMvZGlzdC9EaWFsb2cuanNcIjtcbmltcG9ydCBcIkB1aTUvd2ViY29tcG9uZW50cy9kaXN0L1RpdGxlLmpzXCI7XG5pbXBvcnQgXCJAdWk1L3dlYmNvbXBvbmVudHMvZGlzdC9CdXR0b24uanNcIjtcbmltcG9ydCBcIkB1aTUvd2ViY29tcG9uZW50cy9kaXN0L0xpbmsuanNcIjtcblxuaW1wb3J0IFwiQHVpNS93ZWJjb21wb25lbnRzL2Rpc3QvQmFyLmpzXCI7XG5pbXBvcnQgXCJAdWk1L3dlYmNvbXBvbmVudHMtaWNvbnMvZGlzdC9kZWNsaW5lLmpzXCI7XG5cbnZhciBkaWFsb2dPcGVuZXJMaW5rID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoXCJkaWFsb2dPcGVuZXJMaW5rXCIpO1xudmFyIGRpYWxvZ09wZW5lckJ0biA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKFwiZGlhbG9nT3BlbmVyQnRuXCIpO1xudmFyIGRpYWxvZyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKFwiZGlhbG9nXCIpO1xudmFyIGRpYWxvZ0Nsb3NlcnMgPSBbLi4uZGlhbG9nLnF1ZXJ5U2VsZWN0b3JBbGwoXCIuZGlhbG9nQ2xvc2VyXCIpXTtcblxuZGlhbG9nT3BlbmVyTGluay5hZGRFdmVudExpc3RlbmVyKFwiY2xpY2tcIiwgKCkgPT4ge1xuICAgIGRpYWxvZy5vcGVuID0gdHJ1ZTtcbn0pO1xuZGlhbG9nT3BlbmVyQnRuLmFkZEV2ZW50TGlzdGVuZXIoXCJjbGlja1wiLCAoKSA9PiB7XG4gICAgZGlhbG9nLm9wZW4gPSB0cnVlO1xufSk7XG5kaWFsb2dDbG9zZXJzLmZvckVhY2goYnRuID0-IHtcbiAgICBidG4uYWRkRXZlbnRMaXN0ZW5lcihcImNsaWNrXCIsICgpID0-IHtcbiAgICAgICAgZGlhbG9nLm9wZW4gPSBmYWxzZTtcbiAgICB9KTtcbn0pIn0sIm1haW4uY3NzIjp7Im5hbWUiOiJtYWluLmNzcyIsImNvbnRlbnQiOiIjZGlhbG9nOjpwYXJ0KGhlYWRlciksXG4jZGlhbG9nOjpwYXJ0KGZvb3Rlcikge1xuICAgIHBhZGRpbmctaW5saW5lOiAwO1xufSJ9fQ

Steps to Reproduce

  1. go to provided example
  2. use keyboard to open the dialog
  3. notice the button works fine
  4. notice the link doesn't open the dialog (it actually does, but closes it immediately)

Log Output, Stack Trace or Screenshots

No response

Priority

High

UI5 Web Components Version

2.11.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SuccessFactors

Declaration

  • [x] I’m not disclosing any internal or sensitive information.

ee92 avatar Jun 20 '25 16:06 ee92

Hello @SAP/ui5-webcomponents-topic-b,

Could you please take a look? The issue is reproducible when pressing the link with Enter key

nnaydenow avatar Jun 23 '25 08:06 nnaydenow

This issue has been closed. To reopen, just leave a comment!

github-actions[bot] avatar Jun 30 '25 12:06 github-actions[bot]

:tada: This issue has been resolved in version v2.12.0-rc.3 :tada:

The release is available on v2.12.0-rc.3

Your semantic-release bot :package::rocket:

ui5-webcomponents-bot avatar Jul 03 '25 08:07 ui5-webcomponents-bot