ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

[Table | a11y]: Multiselect table with demandpopin is having color contrast issues

Open lateefsofi opened this issue 1 year ago • 2 comments

Bug Description

Table component in Multiselect mode is having color contracts issue when a row is selected with demand-popin property set image

Affected Component

Table

Expected Behaviour

There should be no color contrast issue

Isolated Example

No response

Steps to Reproduce

  1. Navigate to https://stackblitz.com/edit/js-3j1lsc?file=index.js,package.json,index.html,style.css
  2. select any row and check the contract issues for popin column labels

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.24.8

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • [X] I’m not disclosing any internal or sensitive information.

lateefsofi avatar Oct 15 '24 07:10 lateefsofi

HI colleagues from @SAP/ui5-webcomponents-topic-tbl, can you, please, check if there is an actual contrast ratio issue in selected table row? Best regards, Petya Markova. (UI5 Dispatcher)

PetyaMarkovaBogdanova avatar Oct 15 '24 09:10 PetyaMarkovaBogdanova

Hi @SAP/ui5-webcomponents-core,

this issue is regarding the V1 Table. Could you please have a look from your side? Seems like the colors may be incorrect here.

Best regards, Duc

DonkeyCo avatar Oct 15 '24 12:10 DonkeyCo

Hi @lateefsofi,

The table has been implemented according to its visual specification, and it produces the correct values as per the design guidelines.

Additionally, the component follows the same design implementation as its corresponding control in OpenUI5 (sap.m.ResponsiveTable).

I’ve reached out to the relevant design owner to double-check this.

Best regards,
Nayden

nnaydenow avatar Nov 18 '24 14:11 nnaydenow

Hi @lateefsofi,

The contrast ratio for the sap_horizon theme appears to be within acceptable norms.

As per the guidelines:

  • Text and icons must maintain a contrast ratio of at least 4.5:1 between the foreground and background colors in the default theme.
  • In high-contrast themes, the minimum contrast ratio should be 7:1.

Based on this, I’m closing the incident.

Best regards,
Nayden

nnaydenow avatar Nov 18 '24 15:11 nnaydenow