ui5-webcomponents-react icon indicating copy to clipboard operation
ui5-webcomponents-react copied to clipboard

Dialog: Content part has incorrect padding when being used as Notification Center

Open guilhXavier opened this issue 2 years ago • 2 comments

Describe the bug Whenever we open a popover containing a list of notification groups and notification items, as it opens a Dialog component, the content CSS shadow part has a padding which is not in accordance with Fiori Guidelines as you can see here.

To Reproduce Steps to reproduce the behavior: In Dialog With Content Storybook

  1. Click on the Open Dialog button;
  2. See that there is a padding in the dialog's content.

Expected behavior When used in the notification center, there should be no padding in the content section, as you can see here. Screenshots Actual image Expected image

UI5 Web Components for React Information @ui5/webcomponents version: 1.5.0 @ui5/webcomponents-react version: 0.26.0 Operating System: macOS Monterey 12.5 Browser: Chrome Version 103.0.5060.134 (Official Build) (x86_64)

Additional context This is a request for our internal SAP project.

guilhXavier avatar Aug 03 '22 17:08 guilhXavier

Hi @guilhXavier

you can remove the default padding by using the ::part pseudo Element of the dialog. You can find all available shadow parts here.

Lukas742 avatar Aug 04 '22 06:08 Lukas742

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Inactive issues will be closed after 7 days. Thanks.

github-actions[bot] avatar Aug 19 '22 02:08 github-actions[bot]

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one.

github-actions[bot] avatar Aug 26 '22 02:08 github-actions[bot]