ui5-webcomponents-react icon indicating copy to clipboard operation
ui5-webcomponents-react copied to clipboard

FilterBar: Adapt Filters label is wrong in Portuguese

Open anfavretto opened this issue 3 years ago • 4 comments

Describe the bug The label of the Adapt Filters button on the FilterBar is wrong.

Isolated Example

To Reproduce Steps to reproduce the behavior:

  1. Add the FilterBar component in a screen
  2. Set the language as Portuguese (key "pt")
  3. See the Adapt Filters label as "Ajustar filtros"

Expected behavior Adapt Filters label should be "Adaptar filtros" in Portuguese instead of "Ajustar filtros"

Screenshots Screen Shot 2022-07-18 at 20 17 06

UI5 Web Components for React Information @ui5/webcomponents version: 1.5.0 @ui5/webcomponents-react version: 0.26.0 Operating System: macOS Monterey 12.4 Browser: Chrome

Additional context This is a request for our internal SAP project.

anfavretto avatar Jul 18 '22 23:07 anfavretto

Internal Incident created: 2280143894

MarcusNotheis avatar Jul 25 '22 16:07 MarcusNotheis

Hey @anfavretto, can you try setting the language to pt_PT instead of pt? Then the label should be correctly translated.

MarcusNotheis avatar Jul 28 '22 06:07 MarcusNotheis

Hi @MarcusNotheis, actually right now we are setting as "pt-BR".

anfavretto avatar Jul 28 '22 19:07 anfavretto

I've just compared our translations with the SAPUI5 translations and it looks like both libraries are using Adjustar filtros for pt_BR and pt in general (see here).

If I would change the language to pt_PT, then the label would be adjusted to Adaptar filtros. (see here).

I would assume that this is caused by the fact that we have no explicit translation for pt_BR, so we're falling back to pt. @ilhan007 @vladitasev Would it make sense to add translations for pt_BR as well?

MarcusNotheis avatar Jul 29 '22 05:07 MarcusNotheis

Hey @anfavretto, we had another internal discussion and we think there is nothing we can do here to change the translation. The translation is in sync with SAPUI5 and the translation system is not offering any more possibilities to allow for additional translation for Portuguese - Brazil.

Sorry that I can't give you a more positive answer here.

MarcusNotheis avatar Sep 08 '22 09:09 MarcusNotheis