ui5-tooling icon indicating copy to clipboard operation
ui5-tooling copied to clipboard

self-contained build should resolve view/controllers imported using say sap.ui.jsview/JSView.create api

Open Ya3Sh opened this issue 5 years ago • 2 comments

Expected Behavior

Views and controllers imported in libraries used in an application should be included in the built artifact sap-ui-custom.js.

Current Behavior

Views and controllers imported using sap.ui.jsview are missing from built artifact.

Context

  • UI5 Module Version (output of ui5 --version when using the CLI): 1.2.1
  • Node.js Version: 10.15.1
  • npm Version: 6.4.1
  • OS/Platform: MacOS

Affected components (if known)

Ya3Sh avatar Mar 26 '19 20:03 Ya3Sh

Hi Ya3Sh,

checking this in our sample application I was not able to reproduce the issue you are describing. (Using: https://github.com/SAP/openui5-sample-app) Best would be if you could share a stripped down version of your app to demonstrate the issue.

Best regards Benedikt

bendkt avatar Apr 01 '19 15:04 bendkt

Hi Ya3Sh,

checking this in our sample application I was not able to reproduce the issue you are describing. (Using: https://github.com/SAP/openui5-sample-app) Best would be if you could share a stripped down version of your app to demonstrate the issue.

Best regards Benedikt

Please find attached a simplistic project openui-sample.zip to demonstrate the issue. You can download the project and execute build.sh to build.

As you may notice, the project has a dependency on lib.a.WelcomeDialog control in library "lib.a". lib.a.WelcomeDialog has runtime dependency on lib.a.WelcomeIntro view and controller. You could notice that the view and controller are not part of the generated dist/resources/sap-ui-custom.js. I expect it to be there as WelcomeDialog depend on them.

Hope it helps.

Ya3Sh avatar Apr 01 '19 20:04 Ya3Sh