ui5-language-assistant icon indicating copy to clipboard operation
ui5-language-assistant copied to clipboard

feat: SAP icons in editor or hover

Open uxkjaer opened this issue 3 years ago • 5 comments

Todo:

  • [ ] Settings for showing icons in editor or only on hover
  • [ ] Setting to disable icon hover or editor
  • [ ] On hover functionality
  • [ ] Code completion for icons
  • [ ] Update readme with Icons functionality and prerequisite of SAP-icons fonts installed on machine
  • [ ] Make tests pass
  • [ ] Add integration tests

fixes #509

uxkjaer avatar Oct 21 '22 05:10 uxkjaer

This pull request introduces 5 alerts when merging f4effa82da3f3e881e617342e0b61d2272e2039c into 352164f58429c5535017db21bba628767bcb1708 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

lgtm-com[bot] avatar Oct 21 '22 05:10 lgtm-com[bot]

Should the sap-icon font-family be added to the editor in the extension or should the user set it themselves in the settings? @petermuessig @bd82

uxkjaer avatar Oct 21 '22 05:10 uxkjaer

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Oct 18 '23 14:10 cla-assistant[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Oct 18 '23 14:10 cla-assistant[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Oct 18 '23 14:10 cla-assistant[bot]