spartacus icon indicating copy to clipboard operation
spartacus copied to clipboard

fix: carousel slides container take size of active slide (GH-6980)

Open sebastianfdez opened this issue 4 years ago • 4 comments

Carousel takes the height of the last slide. Active class is given to the active slide so it will set the height of the container.

Closes GH-6980

sebastianfdez avatar Mar 24 '20 14:03 sebastianfdez

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: Matejk00
:x: sebastianfdez
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 24 '20 14:03 CLAassistant

Can some one tell me why the test is failing? Thanks

sebastianfdez avatar Apr 02 '20 08:04 sebastianfdez

@Matejk00 Hi, do you know why the pipeline fails ? Thanks

sebastianfdez avatar May 13 '20 08:05 sebastianfdez

Hey @sebastianfdez, seems that there is an error in your code.

ERROR: projects/storefrontlib/src/shared/components/carousel/carousel.component.html(17,11): Property 'item' does not exist on type 'CarouselComponent'. Did you mean 'items'? An unhandled exception occurred: projects/storefrontlib/src/shared/components/carousel/carousel.component.html(17,11): Property 'item' does not exist on type 'CarouselComponent'. Did you mean 'items'?

I think we can close this PR, since that bug has been fixed.

Matejk00 avatar May 19 '20 09:05 Matejk00

Closing due to many months of inactivity. If still relevant, please update PR with latest develop branch, and re-open with meaningful comments so that it can be evaluated by development team.

giancorderoortiz avatar Nov 14 '23 20:11 giancorderoortiz