spartacus
spartacus copied to clipboard
fix: carousel slides container take size of active slide (GH-6980)
Carousel takes the height of the last slide. Active class is given to the active slide so it will set the height of the container.
Closes GH-6980
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.
:x: Matejk00
:x: sebastianfdez
You have signed the CLA already but the status is still pending? Let us recheck it.
Can some one tell me why the test is failing? Thanks
@Matejk00 Hi, do you know why the pipeline fails ? Thanks
Hey @sebastianfdez, seems that there is an error in your code.
ERROR: projects/storefrontlib/src/shared/components/carousel/carousel.component.html(17,11): Property 'item' does not exist on type 'CarouselComponent'. Did you mean 'items'? An unhandled exception occurred: projects/storefrontlib/src/shared/components/carousel/carousel.component.html(17,11): Property 'item' does not exist on type 'CarouselComponent'. Did you mean 'items'?
I think we can close this PR, since that bug has been fixed.
Closing due to many months of inactivity. If still relevant, please update PR with latest develop branch, and re-open with meaningful comments so that it can be evaluated by development team.