spartacus icon indicating copy to clipboard operation
spartacus copied to clipboard

fix: make ng-select ariaLabelDropdown translateable

Open uroslates opened this issue 2 months ago • 3 comments

Closes: https://jira.tools.sap/browse/CXSPA-11443

uroslates avatar Dec 17 '25 14:12 uroslates

This is one approach to make ng-select ariaLabelDropdown value translateable. Cons of this approach is that we now depend on Dom structure (selector) encasulated in ng-select library implementation. Maning we're prone to it breaking our code W/o us noticing it (even with Unit test in place).

Alternative second approach (maybe cleaner but way more descriptive) is to modify all templates using ng-select and manually append ariaLabelDropdown translated value. This would mean also adding featureToggles everywhere. This is better from perspective of us not depending that much on breaking changes coming from the encapsulated implementation of ng-select component (which this PRs approach is leaning on).

Third approach is to completely wrap ngSelect into custom component. This is even harder to implement.

uroslates avatar Dec 17 '25 14:12 uroslates

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

github-actions[bot] avatar Dec 22 '25 10:12 github-actions[bot]

spartacus    Run #51140

Run Properties:  status check passed Passed #51140  •  git commit 3175aa7729 ℹ️: Merge 667aa9b6ee7ca015cefaaf7b05e0035210880af8 into 3e57ec54ae93056ae0375331df59...
Project spartacus
Branch Review feature/CXSPA-11443
Run status status check passed Passed #51140
Run duration 03m 26s
Commit git commit 3175aa7729 ℹ️: Merge 667aa9b6ee7ca015cefaaf7b05e0035210880af8 into 3e57ec54ae93056ae0375331df59...
Committer Uros Lates
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 101
View all changes introduced in this branch ↗︎

cypress[bot] avatar Dec 22 '25 10:12 cypress[bot]

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

github-actions[bot] avatar Jan 12 '26 10:01 github-actions[bot]