spartacus
spartacus copied to clipboard
SAP
feat(a11y): add aria-label attribute to payment card graphics for Payment Details cards
spartacus
Run #45630
Run Properties:
Passed #45630
8f59e5fae8 ℹ️: Merge 74f160be25d4e2904e8f84892c790229572eedb1 into dff56f86bb872d5aeccd0c8b88fe...
Passed #45630 8f59e5fae8 ℹ️: Merge 74f160be25d4e2904e8f84892c790229572eedb1 into dff56f86bb872d5aeccd0c8b88fe...| Project |
spartacus
|
| Branch Review |
feature/CXSPA-8197
|
| Run status |
|
| Run duration | 13m 59s |
| Commit |
|
| Committer | Uros Lates |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
2
|
Skipped
|
0
|
|
Passing
|
125
|
| ⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
![cypress[bot] avatar](https://avatars.githubusercontent.com/in/9078?v=4 "Published by a pub.dev verified publisher"){kind=small}
@uroslates let's please make some adjustments:
- It seems Maestro and Switch cards were attributed a generic aria-label as "Credit Card" this won't pass the audit since it doesn't communicate the credit card brand to screen reader users, making the interaction harder. Please match alt text with the specific card brands even if the logo is generic.
- Please update "Master Card" as "Mastercard Card"
- Please differentiate the regular Mastercard from "Mastercard Eurocard Card", they currently have the same alt text.
- Please don't forget to add tooltip for each card as requested in the ticket.
