spartacus
spartacus copied to clipboard
CXEC-14762: UI for messaging and file upload
https://jira.tools.sap/browse/CXEC-14762
Created shared messaging and avatar component Using with customer ticketing messaging component Added validation for file upload
Not related to the PR, but maybe let's restructure the components folder in an another ticket or in this one (up to u)
Because if someone were to go to the code, I don't think they would understand where the messaging component is being used and such.
An example to what I'm leaning towards is the order-details filestructure. It's laid out and 'packaged' in a proper way, where one can tell that all those sub folders is part of the order details
I didn't finish reviewing as there's still some things I need to look into in the PR, but overall,
great job
Parth!
Yes, I agree! and thank you!! :)
I was thinking we can divide the feature into 2 parts,
Ticket List
- CustomerTicketingList
- CustomerTicketingCreate
Ticket Details
- CustomerTIcketingReopen
- CustomerTIcketingClose
- CustomerTIcketingDetails
- CustomerTIcketingMessages
- CustomerTicketingDialog
what do you think?
if somehow author, is not available, let's use an icon, such as fas fa-user - user
What do you think? So in the template, you'd have an *ngIf="user"; else anonymous" https://github.com/SAP/spartacus/pull/16085#discussion_r975748589
I hesitated before adding a icon and used this before, but think that's better, added the changes
Just to clarify, this 'mocked' data is pretty redundant since your taking the mocks from here instead customerTicketingService, which I believe that service will also be 'gone' once your working with the data with the actual 'facade' https://github.com/SAP/spartacus/pull/16085#discussion_r975764523
Yes, it's not being used anyway, removing it. this logic would be properly fixed in the next pr.