spartacus icon indicating copy to clipboard operation
spartacus copied to clipboard

Adding ticketing list, styles and table - Feature/CXEC-15925

Open adolfobee opened this issue 2 years ago • 1 comments

Adding ticketing list, styles and table

adolfobee avatar Aug 09 '22 21:08 adolfobee

@developpeurweb / @morganm58

what do you think about having a different 'look and feel' table. Basically, about this statement below, which ties to this request #16059 (review)

! I haven’t changed the way the table looks because we were told to give priority to how it looks in the mockups, so things like all uppercase headers and the thickness of the table I tried to make them look as close as possible to what I perceive in the mockups

Screen Shot 2022-08-31 at 4 50 12 PM

I for one will think it's weird because we have these 'listing' pages, which has all the same 'table' (look and feel wise), but just for customer ticketing, it will be different. What do you think?

Can @morganm58 / @developpeurweb one of you work with Adolfo if really requires the same 'table' (look and feel wise)

The table should follow the look and feel of the existing tables. When in doubt always refer to the spartacus core UX designers and also Miguel( @developpeurweb ) and I (@morganm58) to ask questions.

@adolfobee You can ping me on slack if you have any questions.

morganm58 avatar Sep 01 '22 15:09 morganm58

some unit tests are failing, we are not adding any new unit tests for this PR. but let's just fix the failing ones.

Parthlakhani avatar Sep 27 '22 15:09 Parthlakhani

Screen Shot 2022-09-27 at 12 27 32 PM

  • CHANGED ON column and spacing overall looks a bit weird as compared to mockups. maybe.. it is because of the added padding on left. it should be added for headings as well.
  • Table is not accessible as saved cart and order history, all fields of the tables should be accessible while tabbing.

Parthlakhani avatar Sep 27 '22 16:09 Parthlakhani

Screen Shot 2022-09-27 at 12 41 52 PM

Access assistant is throwing few errors, you can check from adding this extension to chrome.

Parthlakhani avatar Sep 27 '22 16:09 Parthlakhani