spartacus icon indicating copy to clipboard operation
spartacus copied to clipboard

fix: Remove remaining Ng-bootstrap

Open morganm58 opened this issue 2 years ago • 2 comments

fixes CXSPA-759 https://jira.tools.sap/browse/CXSPA-759

morganm58 avatar Jul 22 '22 12:07 morganm58



Test summary

407 0 1 0Flakiness 4


Run details

Project spartacus
Status Passed
Commit 34562fc379 ℹ️
Started Jul 26, 2022 4:04 PM
Ended Jul 26, 2022 4:13 PM
Duration 09:08 💡
OS Linux Ubuntu - 20.04
Browser Electron 91

View run in Cypress Dashboard ➡️


Flakiness

ssr/pages.core-e2e-spec.ts Flakiness
1 SSR > should render homepage
2 SSR > should render PLP
3 SSR > should render PDP
accessibility/product-configurator-tabbing.core-e2e-spec.ts Flakiness
1 Product Configuration > Product Config Tabbing > should allow to navigate with tab key

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Jul 22 '22 12:07 cypress[bot]

NgbModule is also being imported into these files. Do these imports also need to be removed? And if so I would need some help refactoring the files. cart-base-components.module.ts Cart.module.d.ts cart-shared.module.ts Consignment-tracking.component.spec.ts Modal-options.ts Modal.directive.ts Modal.service.ts Tracking-events.component.d.ts tracking-events.component.spec.ts

morganm58 avatar Jul 22 '22 13:07 morganm58

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Mar 03 '23 22:03 cla-assistant[bot]