spartacus
spartacus copied to clipboard

Published 20 hours ago •

Reame
Issues

add cell phone number to address

Open pebarron15 opened this issue 2 years ago • 4 comments

Jun 24 '22 16:06 pebarron15

4 flaky tests on run #38312 ↗︎

0

384

5

0

4

Details:

Merge 061877bc8355000a1a536edcec83064706586c88 into 73a99d61d1d33c4e608db949714f...
Project: spartacus	Commit: `45c8a0f71f ℹ️`
Status: Passed	Duration: 10:57 💡
Started: Feb 1, 2023 3:59 PM	Ended: Feb 1, 2023 4:10 PM

regression/product_configurator/product-configurator-vc-interactive.core-e2e-spec.ts • 1 flaky test • B2C

View Output Video

Test
Product Configuration > Group Status > should set group status for multi level product		`Screenshot`

ssr/pages.core-e2e-spec.ts • 3 flaky tests • SSR

View Output Video

Test
SSR > should render homepage		`Screenshot`
SSR > should render PLP		`Screenshot`
SSR > should render PDP		`Screenshot`

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

Jun 24 '22 17:06 cypress[bot]

Public API changes

:boom: @spartacus/assets

Library no longer can be analyzed with api-extractor. Please check the errors:

:boom: @spartacus/cart/import-export/root

Library no longer can be analyzed with api-extractor. Please check the errors:

:boom: @spartacus/cart

Library no longer can be analyzed with api-extractor. Please check the errors:

:boom: @spartacus/checkout

Library no longer can be analyzed with api-extractor. Please check the errors:

:boom: @spartacus/core

Previous error: undefined New error: ERROR: Failed to fetch entity for import() type node: import("@spartacus/core").Config

:boom: @spartacus/epd-visualization/epd-visualization-api

Library no longer can be analyzed with api-extractor. Please check the errors:

:boom: @spartacus/product/bulk-pricing/occ

Library no longer can be analyzed with api-extractor. Please check the errors:

:boom: @spartacus/product

Library no longer can be analyzed with api-extractor. Please check the errors:

:boom: @spartacus/product/variants/occ

Library no longer can be analyzed with api-extractor. Please check the errors:

:boom: @spartacus/product-configurator

Library no longer can be analyzed with api-extractor. Please check the errors:

:boom: @spartacus/setup/ssr

Library no longer can be analyzed with api-extractor. Please check the errors:

:boom: @spartacus/tracking

Library no longer can be analyzed with api-extractor. Please check the errors:

:boom: @spartacus/tracking/tms

Library no longer can be analyzed with api-extractor. Please check the errors:

:warning: Some entry points are currently impossible to analyze.

Read more

@spartacus/asm/assets - ``
@spartacus/asm/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/asm/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/asm/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/asm - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/asm/root - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/base/assets - ``
@spartacus/cart/base/components/add-to-cart - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/base/components/mini-cart - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/base/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/base/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/base/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/base - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/base/root - ``
@spartacus/cart/import-export/assets - ``
@spartacus/cart/import-export/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/import-export/core - ``
@spartacus/cart/import-export - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/quick-order/assets - ``
@spartacus/cart/quick-order/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/quick-order/core - ``
@spartacus/cart/quick-order - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/quick-order/root - ``
@spartacus/cart/saved-cart/assets - ``
@spartacus/cart/saved-cart/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/saved-cart/core - ``
@spartacus/cart/saved-cart/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/saved-cart - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/saved-cart/root - ``
@spartacus/cart/wish-list/assets - ``
@spartacus/cart/wish-list/components/add-to-wishlist - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/wish-list/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/wish-list/core - ``
@spartacus/cart/wish-list - ``
@spartacus/cart/wish-list/root - ``
@spartacus/cdc/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cdc/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cdc - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cdc/root - ERROR: Failed to fetch entity for import() type node: import("@spartacus/core").Config
@spartacus/cds - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/b2b/assets - ``
@spartacus/checkout/b2b/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/b2b/core - ``
@spartacus/checkout/b2b/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/b2b - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/b2b/root - ``
@spartacus/checkout/base/assets - ``
@spartacus/checkout/base/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/base/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/base/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/base - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/base/root - ``
@spartacus/checkout/scheduled-replenishment/assets - ``
@spartacus/checkout/scheduled-replenishment/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/scheduled-replenishment - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/scheduled-replenishment/root - ``
@spartacus/core - ERROR: Failed to fetch entity for import() type node: import("@spartacus/core").Config
@spartacus/digital-payments/assets - ``
@spartacus/digital-payments - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/epd-visualization/assets - ``
@spartacus/epd-visualization/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/epd-visualization/core - ``
@spartacus/epd-visualization - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/epd-visualization/root - ``
@spartacus/order/assets - ``
@spartacus/order/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/order/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/order/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/order - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/order/root - ``
@spartacus/organization/administration/assets - ``
@spartacus/organization/administration/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/organization/administration/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/organization/administration/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/organization/administration - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/organization/administration/root - ``
@spartacus/organization/order-approval/assets - ``
@spartacus/organization/order-approval - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/organization/order-approval/root - ``
@spartacus/organization - ``
@spartacus/product/bulk-pricing/assets - ``
@spartacus/product/bulk-pricing/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product/bulk-pricing/core - ``
@spartacus/product/bulk-pricing - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product/bulk-pricing/root - ``
@spartacus/product/image-zoom/assets - ``
@spartacus/product/image-zoom/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product/image-zoom - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product/image-zoom/root - ``
@spartacus/product/variants/assets - ``
@spartacus/product/variants/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product/variants - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product/variants/root - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product-configurator/common/assets - ``
@spartacus/product-configurator/common - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product-configurator/rulebased/cpq - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product-configurator/rulebased - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product-configurator/rulebased/root - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product-configurator/textfield - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product-configurator/textfield/root - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/qualtrics/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/qualtrics - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/qualtrics/root - ``
@spartacus/setup - ``
@spartacus/smartedit/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/smartedit - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/smartedit/root - ``
@spartacus/storefinder/assets - ``
@spartacus/storefinder/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/storefinder/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/storefinder/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/storefinder - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/storefinder/root - ``
@spartacus/storefront - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/tracking/personalization/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/tracking/personalization - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/tracking/personalization/root - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/tracking/tms/aep - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/tracking/tms/core - ``
@spartacus/tracking/tms/gtm - ``
@spartacus/user/account/assets - ``
@spartacus/user/account/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/user/account/core - ``
@spartacus/user/account/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/user/account - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/user/account/root - ``
@spartacus/user - ``
@spartacus/user/profile/assets - ``
@spartacus/user/profile/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/user/profile/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/user/profile/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/user/profile - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/user/profile/root - ``

:moneybag: How to debug problems?

Read more

Problem with import() type

It happens when type is deduced by TS based on code and at the same time the deduced type is not present in the file. In this specific case to support api-extractor it's worth to add type declaration explicitly.

Debugging steps:

go to the bot action logs
find api-extractor logs for broken library
check in which file and line the problems exists
build the library locally and check content of the file mentioned in logs (look for import()
add explicit type to problematic source code
build the library once again and verify that the import( is no longer present
commit and push the code with defined type

Jun 24 '22 18:06 github-actions[bot]

I'll await the conversation with Leeann Faessler on E2E tests.

Oct 03 '22 15:10 justinlee01

Sorry @pebarron15 , I am happy with the E2E tests but there are some questions on backwards-compatibility I'd like a more experienced dev to answer.

Oct 17 '22 14:10 justinlee01

@justinlee01 and @Zeyber can you re-review when you get a chance

Oct 26 '22 18:10 pebarron15